Refactoring: Basic Changes (renaming iteration variable, extracting StringFormatter Class, adding explaining variable in JNLP's SimpleRange class, and extracting Interrupted exception logging method)#897
Open
sarvang00 wants to merge 7 commits intoAdoptOpenJDK:masterfrom
Conversation
…rganization and maintainability
…tern, which is used in the extractVersionId method
because test cases should not be messed wit � This reverts commit 48d7374.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In these commits, I have performed some basic refactoring. The changes include: