Skip to content

Samsung Pay compatibility notification should only be showed to Korean users #4629

@ameshkov

Description

@ameshkov

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

4.0 Nightly 96

Environment

- OS: Android 12
- Device: Samsung

Root access

  • Yes, I have it.

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Install AdGuard on a Samsung device
  2. Start protection
  3. Check what notifications it shows

Expected Behavior

It shows a notification about compatibility issues with the Korean phone version.

We should not bother users of all other Samsung phones.

Actual Behavior

We should only show this notification to Korean users only.

There was an argument that this may be a Korean version of the phone used elsewhere.
However, it appears that the Korean Samsung Pay works in South Korea only [0] so this argument is not valid, the users won't be able to use such app anyways.

How we can detect Korean users? I suggest using keyboard layouts for that, just like we detect what filter lists should be enabled.

Screenshots

Screenshot 1:

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions