Objects reuse bugfix, lenient mode, and old objects support#6
Open
omuravskiy wants to merge 7 commits intoAPNIC-net:masterfrom
Open
Objects reuse bugfix, lenient mode, and old objects support#6omuravskiy wants to merge 7 commits intoAPNIC-net:masterfrom
omuravskiy wants to merge 7 commits intoAPNIC-net:masterfrom
Conversation
- Fix byte array re-use between consequently parsed objects - Add support for all remaining subtypes of (deprecated) BGP type - Add lenient parse mode (to parse dump files generated by broken versions of Zebra/Quagga) - Minor bug fixes
This is a terrible bug :(
This is an update message without any withdrawals or announcements
- Parse from String - get originating / transiting AS
- Do not rely on Exceptions for normal control flow - Use StringBuilder instead of StringBuffer when possible - Utility method on ASPath to build string of List of path elements
Also do not overwrite other attributes with UnsupportedAttribute :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple fixes and improvements: