Skip to content

Conversation

@uju09
Copy link
Contributor

@uju09 uju09 commented Nov 22, 2025

Description

This PR removes unused dummy/mock data and outdated asset files that were previously used for testing UI functionality but are no longer referenced anywhere in the codebase.
Cleaning these unnecessary files improves maintainability, reduces project size, and aligns the app with current production assets.

Fixes #555


Type of change

  • Refactor (does not change functionality, e.g. cleanup of unused assets)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Verified unused assets using a custom Dart script scanning the entire lib/ directory.
  • Cross-checked with global search in VS Code to confirm no references to removed assets.
  • Built the application locally to ensure no missing asset errors or warnings were introduced.
  • Confirmed that the app runs as expected after removal.

No functional behavior was changed.


Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (asset cleanup)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

Summary by CodeRabbit

  • Chores
    • Updated Android build and release configuration paths for artifact management.
    • Modified version control settings to include build resources required for the release process.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: uju09 <24bcs012@iiitdwd.ac.in>
Signed-off-by: uju09 <24bcs012@iiitdwd.ac.in>
Signed-off-by: uju09 <24bcs012@iiitdwd.ac.in>
@coderabbitai
Copy link

coderabbitai bot commented Nov 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the Android build and deploy workflow to reference the corrected keystore path in android/app/, introduces a release APK artifact path environment variable, and removes the keystore file (.jks) ignore rule from .gitignore to include keystore files in version control.

Changes

Cohort / File(s) Change Summary
CI/CD Workflow Updates
.github/workflows/build_and_deploy.yml
Updated KEYSTORE_PATH from android/upload-keystore.jks to android/app/upload-keystore.jks, introduced APK_RELEASE_PATH environment variable pointing to apk-release/app-release.apk, and swapped GitHub Release artifact input from env.APK_PATH to env.APK_RELEASE_PATH
Keystore Version Control
android/.gitignore
Removed ignore rule for Java keystore files (*.jks) to enable tracking of keystore files in repository

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • The gitignore change removing the *.jks ignore rule warrants verification that keystore files are intentionally being tracked (potential security consideration if files contain sensitive data)
  • Confirm that the updated KEYSTORE_PATH correctly reflects the actual file location and matches the build system structure
  • Verify that APK_RELEASE_PATH points to the correct artifact generated by the build pipeline

Possibly related PRs

Suggested reviewers

  • M4dhav

Poem

🐰 A rabbit hops through CI paths so clear,
Keystores relocated without fear,
Artifacts renamed, workflows refined,
Git tracks the treasures once confined! 🔑✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b063ecb and e13cb85.

⛔ Files ignored due to path filters (11)
  • assets/fonts/Montserrat-Regular.ttf is excluded by !**/*.ttf
  • assets/images/cover_image_1.jpg is excluded by !**/*.jpg
  • assets/images/cover_image_2.jpg is excluded by !**/*.jpg
  • assets/images/google_icon.png is excluded by !**/*.png
  • assets/mock/cafe_latte.jpeg is excluded by !**/*.jpeg
  • assets/mock/coffee_girl.jpeg is excluded by !**/*.jpeg
  • assets/mock/japan.jpeg is excluded by !**/*.jpeg
  • assets/mock/podcast.jpeg is excluded by !**/*.jpeg
  • assets/mock/sony.jpeg is excluded by !**/*.jpeg
  • assets/svg/default_profile_picture.svg is excluded by !**/*.svg
  • assets/svg/resonate_logo.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • .github/workflows/build_and_deploy.yml (3 hunks)
  • android/.gitignore (0 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

🎉 Welcome @uju09!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@uju09 uju09 closed this Nov 22, 2025
@uju09 uju09 deleted the fix/remove-dummy-data branch November 22, 2025 17:21
@github-actions
Copy link
Contributor

PR Closed - Thank You, @uju09!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

@uju09 uju09 restored the fix/remove-dummy-data branch November 22, 2025 17:43
@uju09 uju09 deleted the fix/remove-dummy-data branch November 22, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dummy data in places across Resonate

1 participant