Skip to content

Conversation

@SimardeepSingh1450
Copy link
Contributor

Description

Added media query and remove maxWidth Property on the refresh button to fix the right-overflow error getting displayed on home screen.

Fixes #209

Type of change

Please delete options that are not relevant.

  • [ ✔️ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested by running on my android device.

Please include screenshots below if applicable :

aossie-issue-ss

Checklist:

  • [ ✔️ ] My code follows the style guidelines of this project
  • [✔️ ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ✔️ ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [ ✔️ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using Getx to get the device constraints. Use an attribute from the UiSizes class.

@SimardeepSingh1450
Copy link
Contributor Author

We are using Getx to get the device constraints. Use an attribute from the UiSizes class.

ok will make the required changes.

@SimardeepSingh1450
Copy link
Contributor Author

@chandansgowda i have changed the maximumSize width using uisizes and removed my mediaquery implementation, please review.

Copy link
Member

@chandansgowda chandansgowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot from two devices with different screen size.

@SimardeepSingh1450
Copy link
Contributor Author

@chandansgowda due to emulator problems on my laptop i can't get screenshot from 2 devices 😅, but here is a screenshot from my device.

@chandansgowda chandansgowda merged commit 5d78cb4 into AOSSIE-Org:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right Overflow by 3.2 pixels

2 participants