Skip to content

Conversation

@ShivamMenda
Copy link
Contributor

Description

The Alignment of the no-room placeholder was not aligned to the center

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Before After

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Tag the PR with the appropriate labels

@ShivamMenda
Copy link
Contributor Author

@chandansgowda This is a ux fix for the no room placeholder alignment.

@chandansgowda
Copy link
Member

@ShivamMenda Can you please recheck the issue on different devices ? I remember this screen having the no room status in the center itseld.

@chandansgowda chandansgowda added bug Something isn't working question Further information is requested labels Oct 16, 2023
@ShivamMenda
Copy link
Contributor Author

@chandansgowda actually the sized box which made it into the centre was changed to a lesser height. But I'll check on other devices.

@chandansgowda chandansgowda removed the question Further information is requested label Oct 18, 2023
@chandansgowda chandansgowda changed the title No room placholder alignment fixed. No room placeholder alignment fixed Oct 18, 2023
@chandansgowda chandansgowda merged commit 4178111 into AOSSIE-Org:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants