Skip to content

feat: Alert before deleting or leaving the audio room #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chandansgowda merged 7 commits into from
Nov 13, 2023
Merged

feat: Alert before deleting or leaving the audio room #182

chandansgowda merged 7 commits into from
Nov 13, 2023

Conversation

@AKASHANGADII
Copy link
Contributor

@AKASHANGADII AKASHANGADII commented Oct 11, 2023 •
edited
Loading

closes #160

@chandansgowda
Copy link
Member

chandansgowda commented Oct 11, 2023

@AKASHANGADII Please add a screen recording of the same.

@chandansgowda chandansgowda added good first issue Good for newcomers aip-2023 Part of AOSSIE Internship Program 2023 labels Oct 11, 2023
@AKASHANGADII
docs : Update README.md
c58d6dd 
The appwrite and livekit logo's aligment corrected and the logo's will be loaded based on the theme
@AKASHANGADII
docs : image link changed
a1b3d26
@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 11, 2023

device-2023-10-11-175030.webm
This the screen recording of the confirmation for deleting the audio room

@chandansgowda chandansgowda changed the title fix : Confirming before deleting or leaving the audio room feat: Alert before deleting or leaving the audio room Oct 11, 2023
@chandansgowda
Copy link
Member

chandansgowda commented Oct 11, 2023

@AKASHANGADII The flow seems to be wrong. Is the room getting deleted properly ??
Coz we are going back and then trying to delete it .

@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 15, 2023

Yeah @chandansgowda I have maintained the same code flow.

@chandansgowda
Copy link
Member

chandansgowda commented Oct 15, 2023

Yes. But we are navigating to the previous screen before deleting the room. Might lead to some inconsistencies.

@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 15, 2023

But I have written code to navigate only after deleting the controller.

@chandansgowda
Copy link
Member

chandansgowda commented Oct 15, 2023

@AKASHANGADII If I'm not wrong, I'm not able to see a circular indicator in the single room screen once the delete dialog is confirmed.

@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 15, 2023

Okay I'll check it.

@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 15, 2023

Hey @chandansgowda .I have added the loading indicator. Please review it.

chandansgowda
chandansgowda requested changes Oct 16, 2023
View reviewed changes
lib/controllers/single_room_controller.dart Outdated
}

Future<void> leaveRoom() async {
Get.dialog(
Copy link
Member

@chandansgowda chandansgowda Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor it as a widget. We might possibly use it many times.

@AKASHANGADII
Copy link
Contributor Author

AKASHANGADII commented Oct 17, 2023

@chandansgowda . I have made the changes. Please look into it.

@chandansgowda
Copy link
Member

chandansgowda commented Nov 13, 2023

Great job @AKASHANGADII 🚀

@chandansgowda chandansgowda merged commit f572981 into AOSSIE-Org:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandansgowda chandansgowda chandansgowda approved these changes

Assignees

@AKASHANGADII AKASHANGADII

Labels

aip-2023 Part of AOSSIE Internship Program 2023 good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Audio room is deleted without confirmation

2 participants

@AKASHANGADII @chandansgowda