Upgrade torch to 1.11.0 by A669015 · Pull Request #19 · AI4SIM/model-collection

A669015 · 2022-03-31T15:31:10Z

This PR upgrades the torch version used to 1.11.0 and associated it the 11.3 cuda version by default in the requirements.

Additionally it:

upgrades the torch-sparse version to be compatible with the default cuda version supported;
fixes the nox installation on CI/CD pipeline (the integrated action was still using the latest python version whatever the python version used in the matrix),
fixes the cuda/torch combination when cuda in not available on the system (that is the case on Github CI/CD),
add nox session verbosity to ON, for easier debug purpose.

github-actions · 2022-03-31T15:33:02Z

Coverage report for weather_forecast/gwd/ use-case

File	Coverage		Missing
All files	`94%`	✅
data.py	`98%`	✅	`157`
models.py	`89%`	✅	`37-40` `90` `99`
trainer.py	`88%`	✅	`75-76` `80`

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against be0a45c

github-actions · 2022-03-31T15:33:12Z

Coverage report for combustion/unets/ use-case

File	Coverage		Missing
All files	`91%`	✅
data.py	`91%`	✅	`59` `70` `72` `113` `123` `129`
models.py	`87%`	✅	`41-42` `45` `48`
trainer.py	`75%`	❌	`59-62` `66-67` `71`
unet.py	`96%`	✅	`83` `89`

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against be0a45c

github-actions · 2022-03-31T15:33:48Z

Coverage report for combustion/gnns/ use-case

File	Coverage		Missing
All files	`80%`	✅
config.py	`68%`	❌	`74-77` `81` `85-90` `94-101`
data.py	`81%`	✅	`110-137` `163` `217`
models.py	`68%`	❌	`85` `116-131` `156-160` `210-214` `234-238`
plotters.py	`98%`	✅	`55-56`
trainer.py	`76%`	❌	`70-75` `79-80`

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against be0a45c

alxyok

a few non-blocking remarks

alxyok · 2022-04-13T08:12:59Z

combustion/gnns/requirements.txt

 pyyaml==6.0
 randomname==0.1.5
-torch==1.9.0
+torch==1.11.0+cu113


we should really make sure the version is aligned with what is installed. containerizing everything and freezing this in a Dockerfile would be nice

Yeah, that is the next step ;)

alxyok · 2022-04-13T08:14:54Z

tools/nox/nox_ref_file.py

+        (bool): True if cuda is available.
+    """
+    try:
+        out = subprocess.run("nvidia-smi", stdout=subprocess.DEVNULL)


is there not a cleaner way to perform this?

There are maybe other ways to do this, but what do you mean by "cleaner" ?

…into fix-torch

* weather_forecast: upgrade torch and adapt nox sessions * combustion/gnns: upgrade torch and fix datamodule * combustion/unets: upgrade torch * ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support * weather_forecast: upgrade torch and adapt nox sessions * combustion/gnns: upgrade torch and fix datamodule * combustion/unets: upgrade torch * ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support * gnns: fix unsused import Co-authored-by: rmslm <76530303+rmslm@users.noreply.github.com>

* combustion: fix flake8 isuues * combustion: adjust last issues * gnns: fix variable names * ai4sim-ci-cd.yml: perfer use nox lib instead of buggy action support * tools: make linting blocker * first implementation of inference GNN R2 to R3 * cli first implementation in lightning * gnns: integrate inferer in gnn use-case * notebooks: add a notebook for inference results * inferer.py: refactor inferer to be generalizable * Converted .md to .rst, Removed useless text, and Added details describing the UC * bugfix syntax * syntax bugfix * Linting-compliancy of combustion/unets (with temporarily? disabled docstring rules) (#21) * Fix bad conflict resolution in GNN (#22) * combustion: fix flake8 isuues * combustion: adjust last issues * gnns: fix variable names * ai4sim-ci-cd.yml: perfer use nox lib instead of buggy action support * tools: make linting blocker * nox_ref_file.py: make build failling is coverage pass under 80% * Upgrade torch to 1.11.0 (#19) * weather_forecast: upgrade torch and adapt nox sessions * combustion/gnns: upgrade torch and fix datamodule * combustion/unets: upgrade torch * ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support * weather_forecast: upgrade torch and adapt nox sessions * combustion/gnns: upgrade torch and fix datamodule * combustion/unets: upgrade torch * ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support * gnns: fix unsused import Co-authored-by: rmslm <76530303+rmslm@users.noreply.github.com> * gnns: add unit tests for inferer.py * inferer.py: fix wrong example path Co-authored-by: root <rami.salem@atos.net> Co-authored-by: alxyok <alxyok@naiama.com> Co-authored-by: Léo Nicoletti <leo.nicoletti@atos.net> Co-authored-by: rmslm <76530303+rmslm@users.noreply.github.com>

* patch GH merge * use the var for branch name everywhere

A669015 requested review from alxyok, cbovalo, leonicoletti and rmslm March 31, 2022 15:31

leonicoletti approved these changes Apr 5, 2022

View reviewed changes

A669015 added 4 commits April 5, 2022 15:40

weather_forecast: upgrade torch and adapt nox sessions

aacbf36

combustion/gnns: upgrade torch and fix datamodule

d3e2d89

combustion/unets: upgrade torch

321f159

ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support

7fd6d0e

A669015 force-pushed the fix-torch branch from d43a882 to 7fd6d0e Compare April 5, 2022 13:43

A669015 added 4 commits April 11, 2022 09:24

weather_forecast: upgrade torch and adapt nox sessions

acb785d

combustion/gnns: upgrade torch and fix datamodule

281096b

combustion/unets: upgrade torch

ec920b8

ai4sim-ci-cd.yml: improve nox sessions verbosity and cuda support

bc8818f

A669015 force-pushed the fix-torch branch from 7fd6d0e to bc8818f Compare April 11, 2022 07:24

alxyok reviewed Apr 13, 2022

View reviewed changes

rmslm approved these changes Apr 14, 2022

View reviewed changes

rmslm and others added 3 commits April 14, 2022 15:19

Merge branch 'main' into fix-torch

639ac1f

Merge branch 'fix-torch' of https://github.com/AI4SIM/model-collection …

35609e5

…into fix-torch

gnns: fix unsused import

be0a45c

A669015 merged commit ea73988 into main Apr 14, 2022

A669015 deleted the fix-torch branch April 14, 2022 13:32

ai4sim-pr-app bot pushed a commit that referenced this pull request Mar 9, 2026

patch GH merge (#19)

5e81bda

* patch GH merge * use the var for branch name everywhere

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade torch to 1.11.0#19

Upgrade torch to 1.11.0#19
A669015 merged 11 commits intomainfrom
fix-torch

A669015 commented Mar 31, 2022

Uh oh!

github-actions bot commented Mar 31, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2022 •

edited

Loading

Uh oh!

alxyok left a comment

Uh oh!

alxyok Apr 13, 2022

Uh oh!

A669015 Apr 13, 2022

Uh oh!

alxyok Apr 13, 2022

Uh oh!

A669015 Apr 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

A669015 commented Mar 31, 2022

Uh oh!

github-actions bot commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alxyok left a comment

Choose a reason for hiding this comment

Uh oh!

alxyok Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

A669015 Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

alxyok Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

A669015 Apr 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 31, 2022 •

edited

Loading

github-actions bot commented Mar 31, 2022 •

edited

Loading

github-actions bot commented Mar 31, 2022 •

edited

Loading