fix system mysql pod label upgrade #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/retest |
eguzki
force-pushed
the
fix-mysql-pod-labels
branch
from
ba42b99 to
6bd8b5b
Compare
|
Code Climate has analyzed commit 6bd8b5b and detected 0 issues on this pull request. View more on Code Climate. |
Member
Author
|
/retest |
Contributor
|
Verified. Labels before upgrading: app: 3scale-api-management
com.redhat.component-name: system-mysql
com.redhat.component-type: application
com.redhat.component-version: "57"
com.redhat.product-name: 3scale
com.redhat.product-version: "2.11"
deployment: system-mysql-1
deploymentConfig: system-mysql
deploymentconfig: system-mysql
threescale_component: system
threescale_component_element: mysqlAfter upgrading app: 3scale-api-management
com.company: Red_Hat
deployment: system-mysql-3
deploymentConfig: system-mysql
deploymentconfig: system-mysql
rht.comp: 3scale
rht.comp_ver: master
rht.prod_name: Red_Hat_Integration
rht.prod_ver: master
rht.subcomp: system-mysql
rht.subcomp_t: application
threescale_component: system
threescale_component_element: mysql |
sergioifg94
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Fix
func (apimanager *APIManager) IsSystemMysqlEnabled() bool. System mysql pod template labels were not upgradedverification steps
Deploy 3scale 2.11 with system mysql. System mysql pod labels are:
Run upgrade to 2.12 procedure. For this step, I just removed the operator and
make runthe version from this PR branch. Check system mysql pod labels:Labels have been upgraded