-
Notifications
You must be signed in to change notification settings - Fork 100
Add OpenTracing configurability for APIcast environments #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd4a016 to
bd78924
Compare
eguzki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good. I dropped some comments
bd78924 to
60735fa
Compare
eguzki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doc about how to see opentracing result when enabled?
That depends on how they install opentracing. They should see the traces in the opentracing ui if successfully working |
…artialKey to better reflect the meaning of the constant
60735fa to
bd50bdc
Compare
|
Code Climate has analyzed commit bd50bdc and detected 24 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
This exposes OpenTracing functionality provided by APIcast into the APIManager CR for the APIcast staging and production environments.
Design
New
spec.apicast.stagingSpec.openTracingandspec.apicast.produtionSpec.openTracingsections have been added in theAPIManagerCR.An example:
openTracingsection are optionalenabledflag is not specified, it defaults tofalsetracingLibraryflag is not specified, it defaults tojaegertracingConfigRefflag is not specified, it defaults to a default tracing configuration specific to the settracingLirary. This default tracing configuration is provided in the APIcast image itselfThe configuration is mounted into the APIcast pod by looking at a
configkey in the provided secret name and mounted in/opt/app-root/src/tracing-configs/tracing-config-<tracing_library_name>-<secret_name>, for example inopt/app-root/src/tracing-configs/tracing-config-jaeger-mysecretnameThe volume tracking annotation mechanism has been implemented for the opentracing-related Volumes in APIcast DeploymentConfigs in order to reconcile addition/removal of them without altering manually mounted ones.
The annotation format for them is:
The Volume name format is: