Skip to content

Stop using nightly images #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miguelsorianod merged 2 commits into from
Jul 19, 2021
Merged

Stop using nightly images #636

miguelsorianod merged 2 commits into from
Jul 19, 2021

Conversation

@miguelsorianod
Copy link
Contributor

@miguelsorianod miguelsorianod commented Jul 14, 2021 •
edited
Loading

This PR performs the following changes:

  • Stop referencing nightly tags for the 3scale components container images (system, zync, ...). Now latest tags are used.
  • Stop building nightly images in the nightly job. It is important to notice that although it removes the build of nightly images it still runs some tests nightly
  • Rename the CSV displayName to 3scale (development latest)
  • Rename the devnightly sample to devlatest
  • Update templates
  • Update code-level defaults to use latest
  • Remove pkg/3scale/amp/manual-templates/amp/build.yml

@miguelsorianod miguelsorianod requested a review from eguzki July 14, 2021 15:43
@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Jul 15, 2021

/retest

1 similar comment
@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Jul 16, 2021

/retest

@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Jul 16, 2021

ready @eguzki

eguzki
eguzki requested changes Jul 19, 2021
View reviewed changes
Copy link
Member

@eguzki eguzki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase the branch to the current master

Overall looking good

@eguzki
Copy link
Member

eguzki commented Jul 19, 2021

images-build workflow should also be removed.

@eguzki
Copy link
Member

eguzki commented Jul 19, 2021

pkg/3scale/amp/manual-templates/amp/build.yml is being used?

@miguelsorianod miguelsorianod force-pushed the stop-using-nightly-images branch from c36e766 to 97b5588 Compare July 19, 2021 11:01
@miguelsorianod
Copy link
Contributor Author

miguelsorianod commented Jul 19, 2021

Done

@miguelsorianod miguelsorianod requested a review from eguzki July 19, 2021 11:01
@miguelsorianod miguelsorianod force-pushed the stop-using-nightly-images branch from 97b5588 to 1dd90ab Compare July 19, 2021 11:05
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jul 19, 2021

Code Climate has analyzed commit 1dd90ab and detected 0 issues on this pull request.

View more on Code Climate.

@miguelsorianod miguelsorianod merged commit ecfc817 into master Jul 19, 2021
@miguelsorianod miguelsorianod deleted the stop-using-nightly-images branch July 19, 2021 12:43
This was referenced Jul 19, 2021
Closed
Merged
Merged
@lvillen lvillen mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eguzki eguzki eguzki approved these changes

Assignees

@eguzki eguzki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miguelsorianod @eguzki