Unit test coverage github.com/3scale/3scale-operator/pkg/controller/helper #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
progress: 35.6% |
eguzki
force-pushed
the
unittests
branch
2 times, most recently
from
39f8e9b to
0500e0c
Compare
eguzki
force-pushed
the
unittests
branch
2 times, most recently
from
c1436b0 to
dd7952b
Compare
eguzki
changed the title
Member
Author
|
/retest |
|
|
||
| cl := fake.NewFakeClient(anotherProviderSecret, providerSecret, devUser1, devUser2, devUser3) | ||
|
|
||
| // Find only not admin users from the same provider account |
Contributor
There was a problem hiding this comment.
Is this comment right? it seems the test looks for admin users and not for "not admin users"
miguelsorianod
approved these changes
May 20, 2021
Contributor
miguelsorianod
left a comment
miguelsorianod
left a comment
There was a problem hiding this comment.
👍 looks good to me. Great work
|
Code Climate has analyzed commit 9ae83a8 and detected 0 issues on this pull request. View more on Code Climate. |
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unittest coverage for
github.com/3scale/3scale-operator/pkg/controller/helperInitially, unittest coverage was 33.8%
After this PR, 42.4%