Separate server start and API setup logic#651
Merged
aalemayhu merged 1 commit into2anki:mainfrom Jun 4, 2022
Renni771:separate-server-start-and-api-setup-logic
Merged
Separate server start and API setup logic#651aalemayhu merged 1 commit into2anki:mainfrom Renni771:separate-server-start-and-api-setup-logic
aalemayhu merged 1 commit into2anki:mainfrom
Renni771:separate-server-start-and-api-setup-logic
Conversation
aalemayhu
approved these changes
May 29, 2022
Contributor
aalemayhu
left a comment
aalemayhu
left a comment
There was a problem hiding this comment.
Strictly speaking this is not a chore as you say in the commit it's a refactor. You can learn more about conventional commits on this website https://www.conventionalcommits.org/en/v1.0.0/
Otherwise LGTM, I will merge it after going through a regression check.
Contributor
|
Sorry for the delay, will merge this but the build is stuck. Closing and re-opening to trigger build. |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Unfortunately have to revert this as it broke the whole login / signup flow. |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.