Revert changes done in #216

[dkotter]

Description of the Change

As reported in #237, the changes made in #216 are causing issues for anyone using the wp_get_attachment_image function to output SVGs. As described in that Issue, we need to be smarter in how we determine the height and width attributes to use instead of just relying on the dimensions for each registered size (since SVGs don't get cropped the same as normal images by WordPress).

This PR reverts the changes introduced in #216 and also adds some additional E2E tests to help us catch these sorts of issues in the future.

Note there is additional work we could look to do here, both fixing what we were attempting to do in #216 and being smarter with how we determine the SVG sizes, as described in this comment.

Closes #237

How to test the Change

1. Ensure general functionality of the plugin still works as expected (you can upload svgs, you can add those into content, etc)
2. Also modify your theme to directly output svgs using wp_get_attachment_image and ensure that no matter what image size you pass in, the full SVG dimensions are used instead (which is previous behavior)

Changelog Entry

Fixed - Revert changes made to how we determine custom dimensions for svgs

Credits

Props @dkotter, @martinpl, @subfighter3, @smerriman, @gigatyrant

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added Critical Flows, Test Cases, and/or End-to-End Tests to cover my change.
• All new and existing tests pass.

[dkotter]

This reverts the changes made in #216 and brings back the functionality for wp_get_attachment_image. In testing with get_image_tag though, that doesn't seem to be working as expected anymore, though seems that's a WordPress core issue and not something we changed (I tested Safe SVG back to 2.0.0 and got the same results).

Basically that function is using the dimensions of the image size passed in instead of the SVG dimensions (basically functions the way wp_get_attachment_image did after the changes in #216, which we're reverting here). Don't need to hold up this PR for that but we should open a new issue to investigate what needs to change to ensure get_image_tag outputs SVGs as expected. Seems the problem lies in our code that looks for height and width set to 1 and replaces those with the custom size. WordPress isn't setting those to 1 anymore so that replacement doesn't work.

I've added E2E tests in this PR for both wp_get_attachment_image and get_image_tag but the get_image_tag ones, while they pass, aren't getting the height and width attributes I'd expect, so once that issue gets fixed, those tests should fail (which is good in this case) and we can fix the tests at that point.

[iamdharmesh]

Code changes look good to me and it tests well. Thanks @dkotter