fix(relayer): match wallet-webapp FeeOptions request shape#966
Open
taylanpince wants to merge 3 commits intomasterfrom
Open
fix(relayer): match wallet-webapp FeeOptions request shape#966taylanpince wants to merge 3 commits intomasterfrom
taylanpince wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
We observed Polygon
Relayer/FeeOptionsfailures for undeployed v3 wallets when the client requests fee options using the guest module as the simulation target.wallet-webapp-v3successfully requests fee options for the same wallet by calling:wallet = <walletAddress>to = <walletAddress>data = Payload.encode(calls, self=<walletAddress>)(raw0x03…bundle)That request shape returns fee options reliably on Polygon.
This PR updates
RpcRelayer.feeOptionsto match the wallet-webapp-v3 request shape:to = walletself = walletThis avoids guest-module simulation pitfalls while still representing the same underlying meta-transaction bundle.
Notes
send-native --broadcastsucceeded for an undeployed wallet.Risk
Low: this only affects the request shape for the FeeOptions call; the returned fee options and the subsequent SendMetaTxn flow remain unchanged.