Add git committers file #396
Conversation
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
LGTM assuming Require review from Code Owners is off.
ACK 748d19c
Looks like this defaults to off and I have not turned it on. |
|
Needs an ack from @apoelstra for |
|
@jamillambert I just update the description because I originally omitted listing you for |
The `corepc` repo is for all things integration testing. Also it provides `bitreq` (HTTP crate), and `corepc-types` (Bitcoin Core JSONRPC types). When integration testing some users (eg `bdk`) use `electrsd` along side `corepc-node` (formerly `bitcoind`). `electrsd` depends on `corepc-node` and every time we release `corepc-node` we have to do a release of `electrsd`. Having them in separate repositories causes friction and makes additional work. Instead we can put them together to hopefully make everyone's life easier (well mine and Ricardo's anyway). Note that `bitcoind` was written by Ricardo. I re-named it, a move I'm now regretting because of the original symmetry with `electrsd`. This import has the blessing of Ricardo and needs an explicit ACK from him before merging. When the CODEOWNERS file is added (rust-bitcoin#396) it should include him as owner of this crate. Import the `electrsd` crate from https://github.com/RCasatta/electrsd/ While HEAD is at commit hash: dc88d81520c9ec507fc830b88a3b92a034dbaf93 `dc88d81: bump version 0.36.0 -> 0.36.1`
The `corepc` repo is for all things integration testing. Also it provides `bitreq` (HTTP crate), and `corepc-types` (Bitcoin Core JSONRPC types). When integration testing some users (eg `bdk`) use `electrsd` along side `corepc-node` (formerly `bitcoind`). `electrsd` depends on `corepc-node` and every time we release `corepc-node` we have to do a release of `electrsd`. Having them in separate repositories causes friction and makes additional work. Instead we can put them together to hopefully make everyone's life easier (well mine and Ricardo's anyway). Note that `bitcoind` was written by Ricardo. I re-named it, a move I'm now regretting because of the original symmetry with `electrsd`. This import has the blessing of Ricardo and needs an explicit ACK from him before merging. When the CODEOWNERS file is added (rust-bitcoin#396) it should include him as owner of this crate. Import the `electrsd` crate from https://github.com/RCasatta/electrsd/ While HEAD is at commit hash: dc88d81520c9ec507fc830b88a3b92a034dbaf93 `dc88d81: bump version 0.36.0 -> 0.36.1`
|
@apoelstra can you ack this please as crate owner of |
|
@TheBlueMatt and @tnull do either of you want to be made code owners of |
|
Ping @apoelstra who now has notifications for this repo set to 'mentions'. |
Sure, feel free to add me. |
|
Sounds good to me. Though if I seem to be AWOL again please ping me and I'll see if my notifications are broken somehow still. utACK 748d19c |
|
Yea I'd be fine reviewing the (rare) bitreq PRs. |
tcharding
dismissed stale reviews from jamillambert and oleonardolima
via
05524ed
tcharding
force-pushed
the
push-xyyqnrpkkwxx
branch
from
748d19c to
05524ed
Compare
|
Force pushed changes based on volunteering in the discussion above and re-wrote the PR description. I took you off |
- Andrew for `jsonrpc` because its his crate. - Jamil for `types` and `client` because he wrote much of the code it `types`. - Ricardo for `node` because its his crate. - Leo for `bitreq` because he offered to help maintain in at the Rust Bitcoin Summit. - Matt and tnull for `bitreq` because they offered below. This PR will need explicit acks from each of these devs please.
tcharding
force-pushed
the
push-xyyqnrpkkwxx
branch
from
05524ed to
e6830d9
Compare
|
Re-ack please @jamillambert |
|
ACK e6830d9 |
|
ACK (at least the bitreq part) e6830d9 |
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
ACK e6830d9
I'm happy with the changes
|
re-ut-ACK e6830d9 |
7 participants
Add a CODEOWNERS file to the project.
jsonrpcbecause its his crate.typesandclientbecause he wrote much of the code ittypes.nodebecause its his crate.bitreqbecause he offered to help maintain in at the Rust Bitcoin Summit.bitreqbecause they offered below.This PR will need explicit acks from each of these devs please.