#529: Expose HTTPMetricHandler #530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is bigger than it needs to be, you only needed to change the visibility. |
Author
|
Created it as a toplevel class. That makes it clear that the handler is a standalone class. Instantiating HttpServer.HTTPMetricHandler might indicate that a server is still involved. |
Contributor
|
I'm not sure how good our tests are here, and I'd don't like splitting logic like this across files too much. |
Contributor
|
Given that my comments remain unaddressed I'm going to close this off. If you're still interesting in a change that only makes this public, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.