Fix WebGL shader and texture memory leak on sketch removal #8418
+188
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical WebGL lifecycle issue where shader programs and textures were never explicitly released from GPU memory when a sketch was destroyed. As a result, applications that repeatedly create and remove WebGL sketches (e.g. hot-reload editors, instance-mode apps, long-running installations) experienced unbounded GPU memory growth.
The fix introduces explicit
dispose()methods for WebGL-backed resources and registers a renderer-level cleanup hook that is automatically invoked whensketch.remove()is called.Impact
Before
remove()After
Changes
1.
p5.Shader.dispose()Adds an explicit teardown path for shader GPU resources.
2.
p5.Texture.dispose()Ensures GPU textures are freed when no longer needed.
3. Renderer-level cleanup hook (
p5.RendererGL)Introduces a centralized cleanup method that disposes all WebGL resources owned by the renderer.
Key resources cleaned:
this.textures)The cleanup is automatically invoked on sketch teardown:
PR Checklist
npm run lintpasses