[ptf][testutils.py::count_matched_packets] Consider only expected packets for timeout#229
Open
vkjammala-arista wants to merge 1 commit intop4lang:mainfrom
Open
[ptf][testutils.py::count_matched_packets] Consider only expected packets for timeout#229vkjammala-arista wants to merge 1 commit intop4lang:mainfrom
vkjammala-arista wants to merge 1 commit intop4lang:mainfrom
Conversation
"count_matched_packets" method is getting stuck in a while loop as long as ptf server port receives any packet (Ex: in dualtor case, we do see continuous ICMP packets on ptf port). Fix is to consider only expected packets w.r.t timeout (similar to "count_matched_packets_all_ports" logic). Signed-off-by: Vinod <vkjammala@arista.com>
vkjammala-arista
force-pushed
the
fix-count-matched-pkts
branch
from
00d305f to
64243ec
Compare
|
I would also like to note that the same logic (added in this PR) is already present in count_matched_packets_all_ports |
Contributor
|
There are some failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count_matched_packetsmethod is getting stuck in a while loop as long as ptf port receives any packet (Ex: in certain testing topologies, protocol packets (like ICMP) on ptf port are causingcount_matched_patchesmethod to stuck waiting for packet poll to fail). Fix is to consider only expected packets w.r.t timeout (similar to existingcount_matched_packets_all_portslogic).See sonic-net/sonic-buildimage#21150 for more details on why this fix is needed.
Testing:
sonic-mgmt tests have been running with this change for quite some time and no issues were seen.