-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chainio: add defer b.Stop() to fix goroutine leak in dispatcher tests #10521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chainio: add defer b.Stop() to fix goroutine leak in dispatcher tests #10521
Conversation
Summary of ChangesHello @DevPatel-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves persistent goroutine leaks identified within the test environments of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to fix goroutine leaks in chainio and watchtower/lookout tests by adding defer b.Stop() and defer l.Stop() calls. While the intention to ensure proper cleanup and prevent leaks is correct and crucial for robust testing, several defer b.Stop() statements in chainio/dispatcher_test.go are either incorrectly placed before variable initialization or are duplicated. These issues will lead to compilation errors or redundant operations, hindering the effectiveness of the cleanup. Please review the specific comments for details on correcting these placements and removing duplicates.
f388b47 to
222bf7e
Compare
Added defer b.Stop() after each NewBlockbeatDispatcher() instantiation in chainio/dispatcher_test.go to properly clean up goroutines and fix leak detection failures.
222bf7e to
3407d97
Compare
Fix goroutine leaks detected in chainio package by adding defer b.Stop() calls to test cleanup.
Changes
Summary
defer b.Stop()afterNewBlockbeatDispatcher()in 6 test functions to ensure proper cleanupTesting
Fixes #10505