Skip to content

Conversation

@DevPatel-11
Copy link

@DevPatel-11 DevPatel-11 commented Jan 23, 2026

Fix goroutine leaks detected in chainio package by adding defer b.Stop() calls to test cleanup.

Changes

  • chainio: Added defer b.Stop() after NewBlockbeatDispatcher() in 6 test functions to ensure proper cleanup

Summary

  • chainio: Added defer b.Stop() after NewBlockbeatDispatcher() in 6 test functions to ensure proper cleanup

Testing

  • chainio tests pass ✓

Fixes #10505

@gemini-code-assist
Copy link

Summary of Changes

Hello @DevPatel-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves persistent goroutine leaks identified within the test environments of the chainio and watchtower/lookout packages. By systematically integrating deferred stop calls for key components, the changes ensure that all background processes initiated during testing are gracefully terminated, leading to more robust and reliable test execution without resource accumulation.

Highlights

  • Goroutine Leak Fix: Addressed goroutine leaks in the chainio and watchtower/lookout test suites by ensuring proper resource cleanup.
  • chainio Test Cleanup: Introduced defer b.Stop() calls after NewBlockbeatDispatcher() initialization in six chainio test functions to prevent leaks.
  • watchtower/lookout Test Cleanup: Added defer l.Stop() calls after NewLookout() in watchtower/lookout test functions for similar cleanup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to fix goroutine leaks in chainio and watchtower/lookout tests by adding defer b.Stop() and defer l.Stop() calls. While the intention to ensure proper cleanup and prevent leaks is correct and crucial for robust testing, several defer b.Stop() statements in chainio/dispatcher_test.go are either incorrectly placed before variable initialization or are duplicated. These issues will lead to compilation errors or redundant operations, hindering the effectiveness of the cleanup. Please review the specific comments for details on correcting these placements and removing duplicates.

@DevPatel-11 DevPatel-11 force-pushed the fix/goroutine-leaks-proper branch from f388b47 to 222bf7e Compare January 23, 2026 05:35
Added defer b.Stop() after each NewBlockbeatDispatcher() instantiation
in chainio/dispatcher_test.go to properly clean up goroutines and fix
leak detection failures.
@DevPatel-11 DevPatel-11 force-pushed the fix/goroutine-leaks-proper branch from 222bf7e to 3407d97 Compare January 23, 2026 06:12
@DevPatel-11 DevPatel-11 changed the title Fix goroutine leaks in chainio and watchtower/lookout tests chainio: add defer b.Stop() to fix goroutine leak in dispatcher tests Jan 23, 2026
@DevPatel-11 DevPatel-11 marked this pull request as draft January 23, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature]: goroutine leak detection

1 participant