chainio: add defer b.Stop() to fix goroutine leak in tests

[DevPatel-11]

Description

This PR fixes the goroutine leak in the chainio package's BlockbeatDispatcher by adding defer b.Stop() to test cleanup.

Fixes

Fixes #10505

Details

The BlockbeatDispatcher.Start() method launches a goroutine that waits indefinitely on a channel. Tests were calling Start() but never calling Stop() to properly shut down the dispatcher. This caused goroutines to hang at test completion, creating memory leaks.

The fix adds defer b.Stop() immediately after creating the dispatcher instance, ensuring proper cleanup when the test ends.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Testing

• I have tested this change with make test
• No test failures introduced

[gemini-code-assist]

Summary of Changes

Hello @DevPatel-11, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a goroutine leak within the chainio package's BlockbeatDispatcher tests. The issue stemmed from BlockbeatDispatcher instances being started but not properly stopped, leading to lingering goroutines. The fix ensures that each dispatcher is gracefully shut down upon test completion, improving test reliability and resource management.

Highlights

• Goroutine Leak Fix: Introduced defer b.Stop() calls in various BlockbeatDispatcher test functions to ensure proper shutdown and prevent goroutine leaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively addresses the goroutine leak in the BlockbeatDispatcher tests by correctly adding defer b.Stop() calls. This ensures proper resource cleanup and prevents goroutines from hanging, improving the stability and correctness of the tests. The changes are concise and well-placed within the test setup.