Fix function bar labels in Screens panel rename mode #1884
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When entering rename mode in the Screens setup (F2 Setup > Screens), the function bar now displays appropriate labels: - F1: Cancel (cancels rename, restores original name) - F2: Done (confirms rename) - F3-F10: blank Previously, the function bar showed stale labels from normal mode (New, MoveUp, MoveDn, Remove, Done) which were non-functional and confusing during rename. Fixes htop-dev#1882
runlevel5
commented
Jan 28, 2026
Comment on lines
+455
to
+456
| ScreensPanel_cleanup(); | ||
| ScreenTabsPanel_cleanup(); |
Author
There was a problem hiding this comment.
I follow the same pattern to free them up
natoscott
approved these changes
Jan 29, 2026
Member
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
LGTM and works nicely, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entering rename mode in the Screens setup (F2 Setup > Screens), the function bar now displays appropriate labels:
Previously, the function bar showed stale labels from normal mode (New, MoveUp, MoveDn, Remove, Done) which were non-functional and confusing during rename.
Visual summary
Fixes #1882