ci: add trap function to look for core files

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the CI quickstart script to enhance its debugging capabilities by ensuring that core dump files are consistently searched for upon script termination. By introducing a global trap mechanism, the logic for detecting core files is centralized, eliminating the need for scattered find commands within individual functions. This change improves the reliability of identifying unexpected core dumps, which is crucial for diagnosing CI failures.

Highlights

• Global Core File Detection: Introduced a new cleanup function that searches for core dump files across the entire directory structure.
• Robust Script Termination Handling: Implemented a trap mechanism to ensure the cleanup function is executed automatically upon script termination, regardless of whether it exits normally or due to an interrupt or termination signal.
• Code Simplification: Removed a redundant find . -name '*core*' command from the quickstart::run_cmake_and_make function, as its functionality is now handled by the global trap.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a trap to ensure core files are searched for when the script exits, for any reason. This is a good improvement for robustness. However, the implementation of the cleanup function has a flaw where it can mask the original exit status of the script, potentially hiding failures in CI. I've suggested a fix to preserve the exit status.

[gemini-code-assist]

The cleanup function, when triggered by the EXIT trap, will cause the script to exit with the status of the last command it runs (io::run find ...), which is likely 0. This can mask the original exit status of the script if it was failing. To preserve the original exit status, the trap handler should ensure it exits with that status.

Suggested change

	function cleanup() {
	local exit_status=$?
	io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
	io::run find . -name '*core*'
	}
	function cleanup() {
	local exit_status=$?
	io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
	io::run find . -name '*core*'
	(exit "${exit_status}")
	}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (74e98fc) to head (17f207e).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15919      +/-   ##
======================================================
- Coverage               92.85%   92.85%   -0.01%     
======================================================
  Files                    2343     2343              
  Lines                  216214   216214              
======================================================
- Hits                   200773   200770       -3     
- Misses                  15441    15444       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.