Skip to content

Conversation

@camillobruni
Copy link
Contributor

Chrome's new tracing extension can return duplicate entries for V8 categories
which in turn breaks the MultiSelect view in the chrome probe.

Add a temporary fix until the extension API on the chrome-side is fixed.

@github-actions
Copy link

🎨 Perfetto UI Build

✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21446412887-1-ui/ui/index.html

@etiennep-chromium
Copy link
Contributor

Add a temporary fix until the extension API on the chrome-side is fixed.

Nit: I'm not sure this should be fixed in the extension. Chrome returns duplicates because the category exists in both chrome and v8; we can ideally fix that in chrome, but it makes sense for the recorder UI to de-duplicate anyways.

@camillobruni
Copy link
Contributor Author

Add a temporary fix until the extension API on the chrome-side is fixed.

Nit: I'm not sure this should be fixed in the extension. Chrome returns duplicates because the category exists in both chrome and v8; we can ideally fix that in chrome, but it makes sense for the recorder UI to de-duplicate anyways.

fair, maybe we can just fix in the chrome-extension instead of the API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants