tp: Save dependent queries as CTEs #4600
Draft
+77
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Isn't this going to regress anyone who is using metric computation? This is not just a codepaths used by explore page but also summarization in Google. |
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21434431227-1-ui/ui/index.html |
Member
Author
It will regress anyone who is executing multiple metrics using the same shared query. I am working on a different fix, to avoid this regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the execution significantly - just add shared queries as CTEs each time they are needed, rather than materializing them upfront. This also makes them more independent, as structured query will never materialize anything now.
This change is required for the current implementation of the Explore Page, in which each node depends on the other nodes in the CTE. As this is a clear simplification, we might go back to the previous implementation.
Add a todo to go back to a tables based lifecycle management when we integrate properly with the Explore Page.