ui: Add Android Input Lifecycle Plugin #4576
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when two datasets of the same src differ by an inner join, there can be cases where the current merge implementation causes rows to be dropped. This change modifies merging by being more strict on the criteria datasets can be merged by - concretely only merging if both src and joins are the same. This is a tradeoff which prioritises correctness over potential performance gain from combining sources.
ivan-chong
changed the base branch from
main
to
dev/ivankc/related-events-visualiser
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21369343360-1-ui/ui/index.html |
ivan-chong
changed the base branch from
dev/ivankc/related-events-visualiser
to
main
ivan-chong
changed the base branch from
main
to
dev/ivankc/related-events-visualiser
ivan-chong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin allows the lifecycle of input events (from twoshay, through system_server and to the frame being drawn) to be computed on the fly for any given input event / frame.
This facilitates the correlation of janky frames to the input events responsible in a trivial way through
These events can be navigated through by clicking on the names of events through the tab, as well as with left and right arrow keys.