Skip to content

Conversation

@robzolkos
Copy link
Contributor

@robzolkos robzolkos commented Jan 16, 2026

Copy-pasted webhook URLs (which is probably the most common way users add them) often include accidental trailing whitespace, which type="url" accepts but URI.parse rejects. Because the controller uses create!/update! this results in a silent failure where the form re-renders with cleared input and no error.

This PR normalizes webhook URLs by stripping leading/trailing whitespace before validation. Since trailing whitespace is not meaningful user input and is the only case that slips past browser validation, normalizing at the model boundary avoids unnecessary UX and code complexity compared to rendering form errors.

This shows the before/after (leaving trailing whitespace re-renders cleared form with no explanation and then with this fix in place).

normalization-fix.mp4

Currently fails because URI.parse rejects URLs with trailing spaces.
Prevents validation errors when users accidentally include trailing spaces in webhook URLs.
@robzolkos robzolkos force-pushed the webhook-form-errors branch from 6a3159d to d8b6ea8 Compare January 16, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant