Contribute: zfs driver and zfs driver shared over ISCSI #5654
Conversation
rsmontero
force-pushed
the
master
branch
4 times, most recently
from
0b269ff to
b94dad5
Compare
| enabled: true | ||
| actions: | ||
| change_authentication: true | ||
| update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
rsmontero
force-pushed
the
master
branch
2 times, most recently
from
9e1985e to
d019bd4
Compare
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_showback_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| settings_auth_tab: true | ||
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| User.two_factor_auth: true | ||
| # Buttons for settings_config_tab | ||
| Settings.change_language: true | ||
| Settings.change_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| User.refresh: true | ||
| User.create_dialog: true | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
| actions: | ||
| # Buttons for settings_info_tab | ||
| User.update_password: true |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
Setting the MACHINE default when parsing VM attributes make the default available when assigning the CD-ROM prefix. NOTE: This prvents to set MACHINE at host or cluster level.
On q35 machines, OpenNebula < 7.0 sets the hd bus to IDE or SATA. As a side effect, CDROM devices using the hd prefix (e.g. context disks) were not attached to the SCSI bus. In some cases, virtio-scsi fails to initialize during boot due to resource exhaustion, causing CDROM devices on that bus not being detected. Observed kernel errors: scsi host6: error handler thread failed to spawn, error = -11 virtio_scsi: probe of virtio1 failed with error -12 (Probably EAGAIN / ENOMEM errors)
RHEL-family on ARM64 does not support SATA bus in the stock libvirt/qemu stack
|
|
||
| const colorBox = `<span style="display:inline-block;width:10px;height:10px;background:${seriesColors[seriesIdx - 1]};border-radius:2px;margin-right:6px;"></span>`; | ||
|
|
||
| tooltip.innerHTML = ` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential code injection vulnerability has been detected, where untrusted input is passed to a method that may execute arbitrary code. This issue allows attackers to inject and execute arbitrary code within the application, which could lead to unauthorized access to sensitive data or other malicious actions. To mitigate this, ensure that all user-supplied input is properly sanitized and validated before being processed. Avoid passing untrusted input to methods like eval, render etc, that can execute arbitrary code. Where possible, use safer alternatives such as parameterized queries or more controlled methods for handling user input. Learn more
|
|
||
| const colorBox = `<span style="display:inline-block;width:10px;height:10px;background:${seriesColors[seriesIdx - 1]};border-radius:2px;margin-right:6px;"></span>`; | ||
|
|
||
| tooltip.innerHTML = ` |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| renderCell: (params) => { | ||
| if (!isVr) return null | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| renderCell: (params) => { | ||
| if (!isVr) return null | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| } | ||
| }, [getSupport]) | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| !isDisconnect && setConnectionState({ state: stateString }) | ||
| } | ||
|
|
||
| guac.current.client.onerror = (status) => { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| RELATIVE_CHARTER_SCHEMA, | ||
| RELATIVE_CHARTER_FIELDS, | ||
| { | ||
| description: (leases) => <FixedLeases leases={leases} />, |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| } | ||
| }, [clearInvalid, optionsOnly, renderValue, values, multiple, onChange]) | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| } | ||
|
|
||
| useEffect(() => { | ||
| guac.current.tunnel.onerror = (status) => { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| } | ||
|
|
||
| const CreateCharterForm = createForm(CHARTER_SCHEMA, CHARTER_FIELDS, { | ||
| description: (leases) => <FixedLeases leases={leases} />, |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
|
|
||
| if (!isSelected || !availableAliases?.length) return null | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
A potential Cross-Site Scripting (XSS) vulnerability has been identified, where untrusted input is being reflected in the response without proper sanitization. This can allow an attacker to inject and execute malicious scripts in the user's browser, potentially compromising sensitive data or application behavior. To mitigate this risk, it is strongly recommended to sanitize or encode all user input before rendering it in the DOM or returning it in a response. Commonly used methods include DOMPurify.sanitize(), encodeURIComponent(), escape(), etc., depending on the use case and framework in use. Learn more - https://cwe.mitre.org/data/definitions/79.html
| // Group by TYPE attribute | ||
| const metadata = userInputsMetadata | ||
| ? mapValues( | ||
| groupBy(userInputsMetadata, (obj) => obj.TYPE || obj.type), |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| groupBy(userInputsMetadata, (obj) => obj.TYPE || obj.type), | ||
| (group) => | ||
| mapValues( | ||
| groupBy(group, (obj) => obj.NAME || obj.name), |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| const groupUserInputs = (userInputs, userInputsMetadata, prefix) => { | ||
| // Group by TYPE attribute | ||
| const metadata = userInputsMetadata | ||
| ? mapValues( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| const rect = over.getBoundingClientRect() | ||
|
|
||
| // wheel scroll zoom | ||
| over.addEventListener('wheel', (e) => { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| /** @type {ObjectSchema} Common schema with relative */ | ||
| const COMMON_SCHEMA = object({ | ||
| [ACTION_FIELD_NAME]: ACTION_FIELD_VALIDATION, | ||
| ARGS: object().when(ACTION_FIELD_NAME, (action) => |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| ? mapValues( | ||
| groupBy(userInputsMetadata, (obj) => obj.TYPE || obj.type), | ||
| (group) => | ||
| mapValues( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| if (pci?.TYPE === 'NIC') return <></> | ||
|
|
||
| // Search for pci devices in the host | ||
| const pciHostDevice = find( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
CSRF protection missing for state-changing requests. Implement CSRF tokens for POST/PUT/PATCH/DELETE operations.
| icon={<RefreshDouble />} | ||
| tooltip={Tr(T.Refresh)} | ||
| isSubmitting={isFetching} | ||
| onClick={() => getLogs()} |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Using Function.prototype.bind and arrows functions as attributes will negatively impact performance in React. Each time the parent is rendered, the function will be re-created and trigger a render of the component causing excessive renders and more memory use.
| helperText={error && !text ? 'Text is required' : ''} | ||
| placeholder="Display value in list" | ||
| /> | ||
| <TextField |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Found non-internationalized text in JSX component label. The label text is directly hardcoded instead of using the i18n translation function. This makes the application difficult to translate and maintain across different languages. Learn more - https://cwe.mitre.org/data/definitions/116.html.
| null | ||
| } | ||
| onChange={(_, newValue) => handleAlias(params.row.id, newValue)} | ||
| renderInput={(args) => ( |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Found non-internationalized text in JSX component label. The label text is directly hardcoded instead of using the i18n translation function. This makes the application difficult to translate and maintain across different languages. Learn more - https://cwe.mitre.org/data/definitions/116.html.
| </Button> | ||
| </Box> | ||
|
|
||
| <TextField |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Found non-internationalized text in JSX component label. The label text is directly hardcoded instead of using the i18n translation function. This makes the application difficult to translate and maintain across different languages. Learn more - https://cwe.mitre.org/data/definitions/116.html.
20 participants
I make available my integration work on zfs, based on the ceph driver.
zfs is for single node and zfs_iscsi for shared
https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git