-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MDEV-38532 Debian packages are missing many server include headers, such as handler.h #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11.4
Are you sure you want to change the base?
Conversation
…uch as handler.h include headers needed to build plugins, same as in RPMs
|
|
| usr/include/mariadb/mysql_com.h | ||
| usr/include/mariadb/mysql_version.h | ||
| usr/include/mariadb/mysqld_error.h | ||
| usr/include/mariadb/server/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the request MDEV-38532 about the server and the package to update is libmaraidbd-dev.install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are in MariaDB-devel package (for example, see this)
So I thought an appropriate Debian counterpart is libmariadb-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libmariadb-dev is intended to be used by C/C++ programs to have the connector client to connect to the server, running from e.g. mariadb-server-core package. The libmariadbd-dev is intended to be used by C/C++ programs that want to embed the server and not depend on a external running MariaDB server at all.
The emdedded server libmariadbd.so.19 is shipped in libmariadbd19t64. I didn't spot that the RPM would have any libmariadbd.so.19 at all, but I am not sure how to browse CentOS package lists.
My guess is that having those server headers in the client library MariaDB-devel is an oversight and nobody is probably using them? Aligning the .deb contents with a .rpm contents is a good principle in general, but only if it is verified that the rpm contents is really intentional and there is a design and real usage behind it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a ready-to-use link that shows the file content of our (not distro) packages, but we put libmariadbd.so.19 in MariaDB-server. I agree that it's not perfect.
libmariadbd-dev indeed is intended to be used by programs that want to embed the server, not for plugin development, so it's not a good choice.
libmariadb-dev is not ideal either, but it's consistent with RPM and it's where these files were historically added — yes, they were added by a request from Slackware MariaDB maintainer, see MDEV-207, commit 9152701
|
Would it be better to put this fix into |
|
It was in RPM for years, I'm just syncing two distribution formats, not introducing a really new feature. |
include headers needed to build plugins, same as in RPMs