Skip to content

Conversation

@vuvova
Copy link
Member

@vuvova vuvova commented Jan 16, 2026

include headers needed to build plugins, same as in RPMs

…uch as handler.h

include headers needed to build plugins, same as in RPMs
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vuvova vuvova changed the base branch from main to 11.4 January 16, 2026 11:29
@vuvova vuvova requested a review from ottok January 16, 2026 11:30
usr/include/mariadb/mysql_com.h
usr/include/mariadb/mysql_version.h
usr/include/mariadb/mysqld_error.h
usr/include/mariadb/server/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the request MDEV-38532 about the server and the package to update is libmaraidbd-dev.install?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are in MariaDB-devel package (for example, see this)

So I thought an appropriate Debian counterpart is libmariadb-dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libmariadb-dev is intended to be used by C/C++ programs to have the connector client to connect to the server, running from e.g. mariadb-server-core package. The libmariadbd-dev is intended to be used by C/C++ programs that want to embed the server and not depend on a external running MariaDB server at all.

The emdedded server libmariadbd.so.19 is shipped in libmariadbd19t64. I didn't spot that the RPM would have any libmariadbd.so.19 at all, but I am not sure how to browse CentOS package lists.

My guess is that having those server headers in the client library MariaDB-devel is an oversight and nobody is probably using them? Aligning the .deb contents with a .rpm contents is a good principle in general, but only if it is verified that the rpm contents is really intentional and there is a design and real usage behind it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ready-to-use link that shows the file content of our (not distro) packages, but we put libmariadbd.so.19 in MariaDB-server. I agree that it's not perfect.

libmariadbd-dev indeed is intended to be used by programs that want to embed the server, not for plugin development, so it's not a good choice.

libmariadb-dev is not ideal either, but it's consistent with RPM and it's where these files were historically added — yes, they were added by a request from Slackware MariaDB maintainer, see MDEV-207, commit 9152701

@ottok
Copy link
Contributor

ottok commented Jan 16, 2026

Would it be better to put this fix into main first and in a stable release only after it is confirmed that the intended use case (storage engine development) actually works?

@vuvova
Copy link
Member Author

vuvova commented Jan 16, 2026

It was in RPM for years, I'm just syncing two distribution formats, not introducing a really new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants