Draft
Conversation
sapphi-red
force-pushed
the
feat/prefresh-plugin
branch
from
6ba3a5c to
0633617
Compare
|
@sapphi-red Do you want this to live in the Prefresh repository? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
@rolldown/plugin-prefreshwhich utilizes Rolldown's native magic string feature.In the synthetic benchmark included in this PR, this plugin is
@swc/plugin-prefresh+@rollup/plugin-swc@prefresh/babel-plugin+@rolldown/plugin-babelI haven't tested in a real world case, and I assume it's quite different as the benchmark above uses build.
The implementation is based on swc-project/plugins/packages/prefresh (Apache License 2.0) and test cases are also adapted from it.
I guess it's better to put this plugin in https://github.com/preactjs/prefresh. But this plugin relies on the internal
oxc-unshadowed-visitorpackage which is not published. So I need to think about publishing that one to do so.