chore: resolve workspace cross-dependencies from source#174
Open
chore: resolve workspace cross-dependencies from source#174
Conversation
Reversean
force-pushed
the
chore/fix-cross-dependencies
branch
from
7418c75 to
4b16d8c
Compare
Add resolve.conditions: ['source'] to vite and vitest configs so workspace deps are resolved from TypeScript source instead of dist. This allows build:modified and test:modified to run against changed packages without requiring their deps to be pre-built. - packages/javascript: - bundle @hawk.so/core instead of externalizing it - move @hawk.so/core to devDependencies - add AGPL-3.0-only to license allow list - add ssr.resolve.conditions for Vite 7 node/SSR environment - packages/sveltekit: - add resolve.conditions: ['source'] - packages/sveltekit/playground: - add resolve.conditions: ['source']
neSpecc
reviewed
Mar 11, 2026
packages/javascript/package.json
Outdated
| "error-stack-parser": "^2.1.4" | ||
| }, | ||
| "devDependencies": { | ||
| "@hawk.so/core": "workspace:^", |
Member
There was a problem hiding this comment.
its not clear for me, why core became a dev dependency?
Member
Author
There was a problem hiding this comment.
Since @hawk.so/core is now bundled into @hawk.so/javascript dist/ (compiled into output) I'm not sure it's runtime-dependency anymore.
And since @hawk.so/core required only during building perhaps it should be used as dev-dependency.
Member
There was a problem hiding this comment.
all dependencies are bundles into dist, for example "error-stack-parser".
So it is still not clear, what is the difference
Member
Author
There was a problem hiding this comment.
Moved @hawk.so/core to dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
Summary
resolve.conditions: ['source']andssr.resolve.conditions: ['source']topackages/javascriptvite and vitest configs, andpackages/sveltekitvite config — so Vite/Vitest resolve cross-workspace imports from TypeScript source instead ofdist/@hawk.so/coreinto@hawk.so/javascriptoutput instead of externalizing it (core is not published to npm separately yet); move core todevDependenciesAGPL-3.0-onlyto the license allow list inrollup-plugin-licensesince core shares the same licenseResult
build:modifiedandtest:modifiednow work from a clean checkout with no pre-builtdist/in any workspace.