Clean up primary-only snapshot DB records on volume expunge#12813
Open
Damans227 wants to merge 4 commits intoapache:4.22from
Open
Clean up primary-only snapshot DB records on volume expunge#12813Damans227 wants to merge 4 commits intoapache:4.22from
Damans227 wants to merge 4 commits intoapache:4.22from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12813 +/- ##
============================================
- Coverage 17.61% 17.60% -0.01%
- Complexity 15662 15665 +3
============================================
Files 5917 5917
Lines 531415 531434 +19
Branches 64973 64978 +5
============================================
- Hits 93588 93580 -8
- Misses 427271 427296 +25
- Partials 10556 10558 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
snapshot.backup.to.secondary=false(KVM + Ceph) and a VM is expunged, Ceph destroys the RBD snapshots along with the volume image, but the DB records (snapshots, snapshot_store_ref) are left behind as undeletable orphans.Fix
In
StorageManagerImpl.cleanupStorage(), clean up primary-only snapshot records before the volume is expunged from storage.Fixes: #12002
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on KVM + Ceph (RBD) with
snapshot.backup.to.secondary=false:How did you try to break this feature and the system with this change?
Tested with snapshots having both primary and secondary refs, and with already-destroyed snapshots, both worked correctly skipped.