Skip to content

Fix add requests dependency#155

Open
AKB0700 wants to merge 5 commits intoDeepLcom:mainfrom
AKB0700:fix-add-requests-dependency
Open

Fix add requests dependency#155
AKB0700 wants to merge 5 commits intoDeepLcom:mainfrom
AKB0700:fix-add-requests-dependency

Conversation

@AKB0700
Copy link

@AKB0700 AKB0700 commented Mar 2, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 20:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a requirements.txt and a basic GitHub Actions workflow to install dependencies, lint, and run pytest—likely to ensure CI can run without relying on Poetry-only installs.

Changes:

  • Added requirements.txt with requests and pydantic<2
  • Added .github/workflows/python-package.yml to run linting and pytest on Python 3.9–3.11

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
requirements.txt Introduces a pip requirements file for CI/local installs
.github/workflows/python-package.yml Adds a GitHub Actions workflow for dependency install, flake8, and pytest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

run: |
python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements install uses pip install -r requirements.txt instead of python -m pip install -r requirements.txt. With a version matrix, calling pip directly can target a different interpreter than the one set up by actions/setup-python, leading to hard-to-debug CI failures.

Suggested change
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
if [ -f requirements.txt ]; then python -m pip install -r requirements.txt; fi

Copilot uses AI. Check for mistakes.
Copy link
Author

@AKB0700 AKB0700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants