Windows - Notification of new Stable version, but it's the same as current #1387
Description
Is there an existing issue for this?
- I have searched the existing issues
Is your issue described in the documentation?
- I have read the documentation
Is your issue present in the nightly release?
- This issue is present in the nightly release
Describe the Bug
I installed the latest Windows version from GitHub earlier.
Looking at the code, this v-if is triggering:
https://localhost:47990/api/config
{
"status": "true",
"platform": "windows",
"version": "0.20.0"
}https://api.github.com/repos/LizardByte/Sunshine/releases/latest
{
...
"name": "v0.20.0",
...
}Bearing this in mind with the code, it seems to be doing:
stableBuildAvailable() {
// have githubVersion (with name: v0.20.0), and version /api/config 0.20.0 - so, continue
if (!this.githubVersion || !this.version) return false;
// Get the GitHub version tag
let v = this.githubVersion.name; // v0.20.0
// If the version starts with a v, remove it
if (v.indexOf("v") === 0) v = v.substring(1); // 0.20.0
// 0.20.0
// .split(".") : ["0", "20", "0"]
// [0] : "0"
// check 0.20.2 !== 0?
return v !== this.version.split(".")[0];
},
I would guess we can remove the splitting and getting the 0th element?
GitHub version, remove v = "0.20.2"
/api/config version = "0.20.2"
Expected Behavior
If I'm on latest stable, don't give render this CTA
Additional Context
No response
Host Operating System
Windows
Operating System Version
11
Architecture
64 bit
Sunshine commit or version
0.20.2
Package
Windows - installer
GPU Type
Nvidia
GPU Model
3080
GPU Driver/Mesa Version
n/a
Capture Method (Linux Only)
No response
Config
n/aApps
No response
Relevant log output
logs disabled