From 6895caa74bca83dafbe58fbebea8358fde2cc3c7 Mon Sep 17 00:00:00 2001 From: Zoltan Toth Date: Tue, 7 May 2019 10:58:22 -0400 Subject: [PATCH 1/5] Update package.json --- package.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 26a7ba4..834cd7c 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,6 @@ { - "name": "javascript-patterns", - "version": "0.1.0", - "private": true, + "name": "design-patterns-game", + "version": "1.0.0", "dependencies": { "prop-types": "^15.7.2", "react": "^16.8.6", From fb1c2d82e6fd8fe74d3d52cce2448325abbb8715 Mon Sep 17 00:00:00 2001 From: Zoltan Toth Date: Tue, 7 May 2019 11:00:09 -0400 Subject: [PATCH 2/5] Update title subheading with better decription --- src/components/Title.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Title.jsx b/src/components/Title.jsx index 1ee39b2..dac2b2e 100644 --- a/src/components/Title.jsx +++ b/src/components/Title.jsx @@ -18,7 +18,7 @@ const Heading = styled.h1` `; const SubHeading = styled.h2` - font: 400 0.925rem 'Karla', sans-serif; + font: 400 0.875rem 'Karla', sans-serif; color: ${props => props.theme.link}; margin: 0.75rem 0 0; `; @@ -26,7 +26,7 @@ const SubHeading = styled.h2` export const Title = () => ( Design Patterns Game - implemented in JavaScript + “Gang of Four” patterns in JavaScript ); From c75c3744d0a547b1b1ec4f01a1c0bf4e0e56371d Mon Sep 17 00:00:00 2001 From: Zoltan Toth Date: Tue, 7 May 2019 12:07:02 -0400 Subject: [PATCH 3/5] Highlight pattern class headers in reference --- src/components/PatternsList.jsx | 6 ++++++ src/styles/themes/theme.dark.js | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/components/PatternsList.jsx b/src/components/PatternsList.jsx index 2e50978..96f0b88 100644 --- a/src/components/PatternsList.jsx +++ b/src/components/PatternsList.jsx @@ -21,6 +21,12 @@ const StyledPatterns = styled.div` color: ${props => props.theme.header}; margin-top: 2.5rem; } + + h3 { + border-bottom: 1px solid ${props => props.theme.text}; + color: ${props => props.theme.header}; + padding-bottom: 1rem; + } `; const PatternsList = () => { diff --git a/src/styles/themes/theme.dark.js b/src/styles/themes/theme.dark.js index 8cea383..910bd33 100644 --- a/src/styles/themes/theme.dark.js +++ b/src/styles/themes/theme.dark.js @@ -36,7 +36,7 @@ export const themeDark = { toggleActiveBorder: C.SILVER, // text and header - header: C.GRAY, + header: C.WILD_SAND, text: C.SILVER, border: C.TUNDORA From b6e5d8c4a25116dc69374b6a1c3b28f4c168b660 Mon Sep 17 00:00:00 2001 From: Zoltan Toth Date: Tue, 7 May 2019 12:09:01 -0400 Subject: [PATCH 4/5] Update snapshots with subtitles content and styling changes --- __tests__/components/__snapshots__/Header.test.js.snap | 8 ++++---- .../components/__snapshots__/PatternsList.test.js.snap | 5 +++++ __tests__/components/__snapshots__/Title.test.js.snap | 8 ++++---- __tests__/pages/__snapshots__/About.test.js.snap | 2 +- __tests__/pages/__snapshots__/Patterns.test.js.snap | 5 +++++ 5 files changed, 19 insertions(+), 9 deletions(-) diff --git a/__tests__/components/__snapshots__/Header.test.js.snap b/__tests__/components/__snapshots__/Header.test.js.snap index dcca459..35aa018 100644 --- a/__tests__/components/__snapshots__/Header.test.js.snap +++ b/__tests__/components/__snapshots__/Header.test.js.snap @@ -53,7 +53,7 @@ exports[`
component renders with DARK theme 1`] = ` } .c8 { - font: 400 0.925rem 'Karla',sans-serif; + font: 400 0.875rem 'Karla',sans-serif; color: #C8C8C8; margin: 0.75rem 0 0; } @@ -226,7 +226,7 @@ exports[`
component renders with DARK theme 1`] = `

- implemented in JavaScript + “Gang of Four” patterns in JavaScript

@@ -286,7 +286,7 @@ exports[`
component renders with LIGHT theme 1`] = ` } .c8 { - font: 400 0.925rem 'Karla',sans-serif; + font: 400 0.875rem 'Karla',sans-serif; color: #6F256F; margin: 0.75rem 0 0; } @@ -459,7 +459,7 @@ exports[`
component renders with LIGHT theme 1`] = `

- implemented in JavaScript + “Gang of Four” patterns in JavaScript

diff --git a/__tests__/components/__snapshots__/PatternsList.test.js.snap b/__tests__/components/__snapshots__/PatternsList.test.js.snap index b0dac56..88566c5 100644 --- a/__tests__/components/__snapshots__/PatternsList.test.js.snap +++ b/__tests__/components/__snapshots__/PatternsList.test.js.snap @@ -16,6 +16,11 @@ exports[`REFERENCE - Patterns List renders all the patterns 1`] = ` margin-top: 2.5rem; } +.c0 h3 { + border-bottom: 1px solid; + padding-bottom: 1rem; +} +
diff --git a/__tests__/components/__snapshots__/Title.test.js.snap b/__tests__/components/__snapshots__/Title.test.js.snap index d5c6ad4..a0e1c4a 100644 --- a/__tests__/components/__snapshots__/Title.test.js.snap +++ b/__tests__/components/__snapshots__/Title.test.js.snap @@ -18,7 +18,7 @@ exports[` component renders with a DARK theme 1`] = ` } .c2 { - font: 400 0.925rem 'Karla',sans-serif; + font: 400 0.875rem 'Karla',sans-serif; color: #C8C8C8; margin: 0.75rem 0 0; } @@ -34,7 +34,7 @@ exports[`<Title /> component renders with a DARK theme 1`] = ` <h2 className="c2" > - implemented in JavaScript + “Gang of Four” patterns in JavaScript </h2> </div> `; @@ -57,7 +57,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = ` } .c2 { - font: 400 0.925rem 'Karla',sans-serif; + font: 400 0.875rem 'Karla',sans-serif; color: #6F256F; margin: 0.75rem 0 0; } @@ -73,7 +73,7 @@ exports[`<Title /> component renders with a LIGHT theme 1`] = ` <h2 className="c2" > - implemented in JavaScript + “Gang of Four” patterns in JavaScript </h2> </div> `; diff --git a/__tests__/pages/__snapshots__/About.test.js.snap b/__tests__/pages/__snapshots__/About.test.js.snap index d2c9047..5c53576 100644 --- a/__tests__/pages/__snapshots__/About.test.js.snap +++ b/__tests__/pages/__snapshots__/About.test.js.snap @@ -16,7 +16,7 @@ exports[`About page renders with a DARK theme 1`] = ` } .c1 { - color: #888888; + color: #F5F5F5; margin-top: 2rem; } diff --git a/__tests__/pages/__snapshots__/Patterns.test.js.snap b/__tests__/pages/__snapshots__/Patterns.test.js.snap index eb28cce..2d00123 100644 --- a/__tests__/pages/__snapshots__/Patterns.test.js.snap +++ b/__tests__/pages/__snapshots__/Patterns.test.js.snap @@ -16,6 +16,11 @@ exports[`Patterns page renders the Patterns list 1`] = ` margin-top: 2.5rem; } +.c0 h3 { + border-bottom: 1px solid; + padding-bottom: 1rem; +} + <div className="c0" > From dabaa4bd28566e0014f0808b02442af0a5d5458b Mon Sep 17 00:00:00 2001 From: Zoltan Toth <contact@zoltantoth.com> Date: Tue, 7 May 2019 12:10:28 -0400 Subject: [PATCH 5/5] Update README with secure link to game --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 27378a5..cc37bb0 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Design Patterns - a quick game to test your familiarity with the 'Gang of Four' design patterns implemented in JS. -### :zap: [PLAY HERE](http://designpatternsgame.com/) +### :zap: [PLAY HERE](https://designpatternsgame.com/) ![Design Patterns - game results screenshot](/static/screenshot.png?sanitize=true&raw=true)