From cee190378269e74f8dbcd647c09939a6c77e6a77 Mon Sep 17 00:00:00 2001 From: ghusharib Date: Tue, 25 Jan 2022 18:05:46 +0000 Subject: [PATCH 1/4] Add query for ghush --- src/main/java/com/develogical/QueryProcessor.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/java/com/develogical/QueryProcessor.java b/src/main/java/com/develogical/QueryProcessor.java index 9d20fd3f..2bd77e9f 100644 --- a/src/main/java/com/develogical/QueryProcessor.java +++ b/src/main/java/com/develogical/QueryProcessor.java @@ -12,6 +12,11 @@ public String process(String query) { if (query.toLowerCase().contains("imperial")) { return "Imperial College is a university in London"; } + + if (query.toLowerCase().contains("ghush")) { + return "A Fourth Year Computing Student at Imperial College London"; + } + return ""; } } From e906a262b2a645c87cdd437be13d14953f1bec24 Mon Sep 17 00:00:00 2001 From: ghusharib Date: Tue, 25 Jan 2022 18:10:55 +0000 Subject: [PATCH 2/4] Add full stop --- src/main/java/com/develogical/QueryProcessor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/develogical/QueryProcessor.java b/src/main/java/com/develogical/QueryProcessor.java index 2bd77e9f..ae712dcc 100644 --- a/src/main/java/com/develogical/QueryProcessor.java +++ b/src/main/java/com/develogical/QueryProcessor.java @@ -14,7 +14,7 @@ public String process(String query) { } if (query.toLowerCase().contains("ghush")) { - return "A Fourth Year Computing Student at Imperial College London"; + return "A Fourth Year Computing Student at Imperial College London."; } return ""; From 7d3ededa7c721896778f1f991a699bf2cad09760 Mon Sep 17 00:00:00 2001 From: ghusharib Date: Tue, 25 Jan 2022 18:34:45 +0000 Subject: [PATCH 3/4] Add heroku deployment stage --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e0a5fa55..4dfb797c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -24,5 +24,5 @@ jobs: - uses: akhileshns/heroku-deploy@v3.12.12 with: heroku_api_key: ${{secrets.HEROKU_API_KEY}} - heroku_app_name: "horse-battery-66" - heroku_email: "jsmith@example.com" \ No newline at end of file + heroku_app_name: "cherry-cola-23" + heroku_email: "mgc18@ic.ac.uk" From 60ce1c793bba4c468205ce869cffbb09403afaef Mon Sep 17 00:00:00 2001 From: ghusharib Date: Tue, 25 Jan 2022 18:37:05 +0000 Subject: [PATCH 4/4] Add tests for query processor --- src/test/java/com/develogical/QueryProcessorTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/java/com/develogical/QueryProcessorTest.java b/src/test/java/com/develogical/QueryProcessorTest.java index 5a1559b7..c61e9aa6 100644 --- a/src/test/java/com/develogical/QueryProcessorTest.java +++ b/src/test/java/com/develogical/QueryProcessorTest.java @@ -26,6 +26,12 @@ public void knowsAboutImperial() throws Exception { containsString("university")); } + @Test + public void knowsAboutGhush() throws Exception { + assertThat(queryProcessor.process("Ghush"), + containsString("Student")); + } + @Test public void isNotCaseSensitive() throws Exception { assertThat(queryProcessor.process("shakespeare"), containsString("playwright"));