From e0bb94335cf044d5bb8ef0f8348cfeab18c2b847 Mon Sep 17 00:00:00 2001 From: Zakaria Tahri <101801384+Zakariathr22@users.noreply.github.com> Date: Sun, 20 Jul 2025 10:17:14 +0100 Subject: [PATCH 1/6] Add warning for Fluent-only icons not available on Windows 10 --- WinUIGallery/Models/IconData.cs | 1 + .../ControlPages/Design/IconographyPage.xaml | 58 +++-- WinUIGallery/Samples/Data/IconsData.json | 204 ++++++++++++------ .../Samples/Data/IconsDataSchema.json | 60 +++--- 4 files changed, 216 insertions(+), 107 deletions(-) diff --git a/WinUIGallery/Models/IconData.cs b/WinUIGallery/Models/IconData.cs index 58e8f12ad..d1d798c03 100644 --- a/WinUIGallery/Models/IconData.cs +++ b/WinUIGallery/Models/IconData.cs @@ -13,6 +13,7 @@ public class IconData public string Name { get; set; } public string Code { get; set; } public string[] Tags { get; set; } = []; + public bool IsSegoeFluentOnly { get; set; } public string Character => char.ConvertFromUtf32(Convert.ToInt32(Code, 16)); public string CodeGlyph => "\\u" + Code; diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index 0128a8c2b..d5fd3dc1d 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -52,6 +52,15 @@ BorderBrush="{ThemeResource CardStrokeColorDefaultBrush}" BorderThickness="1" CornerRadius="{StaticResource ControlCornerRadius}"> + + + - - - + + + + + + + + + + + + + + + + + Date: Sun, 20 Jul 2025 17:37:04 +0100 Subject: [PATCH 2/6] Update WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml Co-authored-by: Niels Laute --- WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index d5fd3dc1d..537d09edb 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -222,7 +222,7 @@ HorizontalAlignment="Stretch" Visibility="{Binding SelectedItem.IsSegoeFluentOnly}"> - + Date: Sun, 20 Jul 2025 17:37:13 +0100 Subject: [PATCH 3/6] Update WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml Co-authored-by: Niels Laute --- WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index 537d09edb..0bdfa801b 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -204,7 +204,7 @@ - + Date: Sun, 20 Jul 2025 18:46:29 +0100 Subject: [PATCH 4/6] Remove warning icon from the cards --- .../Samples/ControlPages/Design/IconographyPage.xaml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index d5fd3dc1d..1897da98c 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -53,14 +53,6 @@ BorderThickness="1" CornerRadius="{StaticResource ControlCornerRadius}"> - - Date: Sun, 20 Jul 2025 18:47:45 +0100 Subject: [PATCH 5/6] Update the warning message and add a tooltip for additional clarity --- .../Samples/ControlPages/Design/IconographyPage.xaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index 1897da98c..c5185e481 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -212,7 +212,8 @@ + Visibility="{Binding SelectedItem.IsSegoeFluentOnly}" + ToolTipService.ToolTip="This icon is only available in Segoe Fluent Icons (the default icon font on Windows 11). On Windows 10, MDL2 is used by default, so the icon may not appear unless Segoe Fluent Icons is installed."> @@ -224,9 +225,10 @@ VerticalAlignment="Top" /> + Foreground="{ThemeResource SystemFillColorCriticalBrush}" + VerticalAlignment="Top" /> Date: Mon, 21 Jul 2025 06:07:59 +0200 Subject: [PATCH 6/6] Update WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml --- WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml index b01ad27bc..326f0eab5 100644 --- a/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml +++ b/WinUIGallery/Samples/ControlPages/Design/IconographyPage.xaml @@ -213,7 +213,7 @@ + ToolTipService.ToolTip="This icon is only available in Segoe Fluent Icons (the default icon font on Windows 11). On Windows 10, Segoe MDL2 Assets is used by default, so the icon may not appear unless Segoe Fluent Icons is installed.">