diff --git a/.github/workflows/buf.yaml b/.github/workflows/buf.yaml index 5b76d4a9d..e7a20fff4 100644 --- a/.github/workflows/buf.yaml +++ b/.github/workflows/buf.yaml @@ -42,6 +42,7 @@ jobs: steps: - uses: actions/checkout@v3 - uses: bufbuild/buf-setup-action@v1 - - uses: bufbuild/buf-breaking-action@v1 - with: - against: 'https://github.com/${{ github.repository }}.git#branch=main' +# TODO (arm-versioning): Arm versioning by removing the comments of the following lines +# - uses: bufbuild/buf-breaking-action@v1 +# with: +# against: 'https://github.com/${{ github.repository }}.git#branch=main' diff --git a/.github/workflows/publish-bufs.yaml b/.github/workflows/publish-bufs.yaml index 9415a76b9..aa9b378b0 100644 --- a/.github/workflows/publish-bufs.yaml +++ b/.github/workflows/publish-bufs.yaml @@ -20,11 +20,13 @@ jobs: fetch-depth: 2 - uses: bufbuild/buf-setup-action@v1 - uses: bufbuild/buf-lint-action@v1 - - name: Check for illegal breakage + # TODO (arm-versioning): Arm versioning by remove the comment of ONLY the next line + # - name: Check for illegal breakage # Only deletions are allowed. Breaking updates must happen in a new version of the package(s) in question. # This is just a sanity check! # For example it allows you to delete files from the latest version of a package (depending on context that might even be ok). - run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi + # TODO (arm-versioning): Arm versioning by remove the comment of the next line + # run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi - name: Has breakage? id: breaking # We previously checked if any illegal breakage occurred, now check if we have breakage _at all_ @@ -50,7 +52,8 @@ jobs: run: | BUMP="patch" if [ "$BREAKING" = "true" ]; then - BUMP="major" + # TODO (arm-versioning): Arm versioning by replacing the following "minor" with "major" + BUMP="minor" elif [ "$NEW_PKG" = "true" ]; then BUMP="minor" else diff --git a/README.md b/README.md index cecfd1e0c..4736aec50 100644 --- a/README.md +++ b/README.md @@ -20,3 +20,9 @@ In the context of a service directory you should be able to use ``` to build the corresponding docker image as well. +## Temporary advises + +### Arm versioning + +[We disarmed the versioning for pre-production.](https://github.com/helpwave/services/issues/125). +To arm the versioning, search for "arm-versioning" in the codebase.