From 699c42f8e4a29557facf6e3ff45b30a30666605e Mon Sep 17 00:00:00 2001 From: David Callizaya Date: Mon, 5 Feb 2024 17:53:10 -0400 Subject: [PATCH 1/4] Fix ellipsis applies only to inline children --- resources/js/requests/components/RequestsListing.vue | 2 +- resources/js/tasks/components/TasksList.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue index 266daaf587..bdf58a6631 100644 --- a/resources/js/requests/components/RequestsListing.vue +++ b/resources/js/requests/components/RequestsListing.vue @@ -46,7 +46,7 @@ :class="{ 'pm-table-truncate': header.truncate }" :style="{ maxWidth: header.width + 'px' }" > -
+ -
+ Date: Mon, 5 Feb 2024 17:54:16 -0400 Subject: [PATCH 2/4] Enable truncate to request_title --- resources/js/requests/components/RequestsListing.vue | 2 ++ resources/js/tasks/components/TasksList.vue | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue index bdf58a6631..2fe12751d6 100644 --- a/resources/js/requests/components/RequestsListing.vue +++ b/resources/js/requests/components/RequestsListing.vue @@ -193,6 +193,8 @@ export default { break; case "case_title": field.name = "__slot:case_title"; + // eslint-disable-next-line no-param-reassign + column.truncate = true; break; default: field.name = column.name || column.field; diff --git a/resources/js/tasks/components/TasksList.vue b/resources/js/tasks/components/TasksList.vue index c80104be0d..1f6b8f901f 100644 --- a/resources/js/tasks/components/TasksList.vue +++ b/resources/js/tasks/components/TasksList.vue @@ -289,8 +289,13 @@ export default { `; }, setupColumns() { - const columns = this.getColumns(); this.tableHeaders = this.getColumns(); + this.tableHeaders.forEach((column) => { + if (column.field === "case_title") { + // eslint-disable-next-line no-param-reassign + column.truncate = true; + } + }); }, getColumns() { if (this.$props.columns) { From 834b54e263dc556eb408afb8cb96de6ac270cbca Mon Sep 17 00:00:00 2001 From: David Callizaya Date: Mon, 5 Feb 2024 18:03:02 -0400 Subject: [PATCH 3/4] Add ellipsis to active tasks --- resources/js/requests/components/RequestsListing.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue index 2fe12751d6..9a3620000c 100644 --- a/resources/js/requests/components/RequestsListing.vue +++ b/resources/js/requests/components/RequestsListing.vue @@ -334,7 +334,7 @@ export default { let htmlString = ''; for (const task of value) { htmlString += ` -
+
${task.element_name} From 2260d0a717fa93625eee83ff9e3b69df660e9770 Mon Sep 17 00:00:00 2001 From: David Callizaya Date: Tue, 6 Feb 2024 11:32:02 -0400 Subject: [PATCH 4/4] No needed, configured in SS --- resources/js/requests/components/RequestsListing.vue | 2 -- resources/js/tasks/components/TasksList.vue | 6 ------ 2 files changed, 8 deletions(-) diff --git a/resources/js/requests/components/RequestsListing.vue b/resources/js/requests/components/RequestsListing.vue index 9a3620000c..74318c0494 100644 --- a/resources/js/requests/components/RequestsListing.vue +++ b/resources/js/requests/components/RequestsListing.vue @@ -193,8 +193,6 @@ export default { break; case "case_title": field.name = "__slot:case_title"; - // eslint-disable-next-line no-param-reassign - column.truncate = true; break; default: field.name = column.name || column.field; diff --git a/resources/js/tasks/components/TasksList.vue b/resources/js/tasks/components/TasksList.vue index 1f6b8f901f..4dded80ef9 100644 --- a/resources/js/tasks/components/TasksList.vue +++ b/resources/js/tasks/components/TasksList.vue @@ -290,12 +290,6 @@ export default { }, setupColumns() { this.tableHeaders = this.getColumns(); - this.tableHeaders.forEach((column) => { - if (column.field === "case_title") { - // eslint-disable-next-line no-param-reassign - column.truncate = true; - } - }); }, getColumns() { if (this.$props.columns) {