From 1e26c4e15285cb187cff578f992f110b8c5532a1 Mon Sep 17 00:00:00 2001 From: Pranay Prakash Date: Sun, 24 Jun 2018 22:49:02 -0700 Subject: [PATCH 1/5] Update issue templates --- .github/ISSUE_TEMPLATE/tutorial-pr.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/tutorial-pr.md diff --git a/.github/ISSUE_TEMPLATE/tutorial-pr.md b/.github/ISSUE_TEMPLATE/tutorial-pr.md new file mode 100644 index 000000000..95807e085 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/tutorial-pr.md @@ -0,0 +1,11 @@ +--- +name: Tutorial PR +about: Making a Pull Request + +--- + +If you're making a pull request for a part of the tutorial on https://zeit.co to setup Github Integration, that's awesome! You're almost there 🎉 + +Make sure of these 2 things before making the pull request: +1. This Pull Request is against your own fork of the project and not the [zeit/now-github-starter](https://github.com/zeit/now-github-starter) repo +2. Your Pull Request includes a `now.json` file with configuration settings. To get started, the file can even just contain `{}` and nothing else. From c09cdc829ca9b115e3493f37e5faa64f356d46ac Mon Sep 17 00:00:00 2001 From: Pranay Prakash Date: Sun, 24 Jun 2018 22:50:39 -0700 Subject: [PATCH 2/5] make it a PR template --- .github/{ISSUE_TEMPLATE => PULL_REQUEST_TEMPLATE}/tutorial-pr.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{ISSUE_TEMPLATE => PULL_REQUEST_TEMPLATE}/tutorial-pr.md (100%) diff --git a/.github/ISSUE_TEMPLATE/tutorial-pr.md b/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md similarity index 100% rename from .github/ISSUE_TEMPLATE/tutorial-pr.md rename to .github/PULL_REQUEST_TEMPLATE/tutorial-pr.md From 3353064702f4d8c189aa10abf0356ec2ff3f9d13 Mon Sep 17 00:00:00 2001 From: Pranay Prakash Date: Sun, 24 Jun 2018 22:54:09 -0700 Subject: [PATCH 3/5] fix about lin --- .github/PULL_REQUEST_TEMPLATE/tutorial-pr.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md b/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md index 95807e085..e6250a0de 100644 --- a/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md +++ b/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md @@ -1,11 +1,12 @@ --- name: Tutorial PR -about: Making a Pull Request +about: Making a Pull Request for the ZEIT Getting Started tutorial? --- If you're making a pull request for a part of the tutorial on https://zeit.co to setup Github Integration, that's awesome! You're almost there 🎉 Make sure of these 2 things before making the pull request: -1. This Pull Request is against your own fork of the project and not the [zeit/now-github-starter](https://github.com/zeit/now-github-starter) repo -2. Your Pull Request includes a `now.json` file with configuration settings. To get started, the file can even just contain `{}` and nothing else. + +1. This Pull Request is against your own fork of the project and not the [zeit/now-github-starter](https://github.com/zeit/now-github-starter) repo +2. Your Pull Request includes a `now.json` file with configuration settings. To get started, the file can even just contain `{}` and nothing else. From 41f45ebd052815ccf312abdc0a827ee27af812c8 Mon Sep 17 00:00:00 2001 From: Pranay Prakash Date: Sun, 24 Jun 2018 23:00:43 -0700 Subject: [PATCH 4/5] fix PR template --- .../tutorial-pr.md => PULL_REQUEST_TEMPLATE.md | 0 now.json | 1 - 2 files changed, 1 deletion(-) rename .github/PULL_REQUEST_TEMPLATE/tutorial-pr.md => PULL_REQUEST_TEMPLATE.md (100%) delete mode 100644 now.json diff --git a/.github/PULL_REQUEST_TEMPLATE/tutorial-pr.md b/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE/tutorial-pr.md rename to PULL_REQUEST_TEMPLATE.md diff --git a/now.json b/now.json deleted file mode 100644 index 0967ef424..000000000 --- a/now.json +++ /dev/null @@ -1 +0,0 @@ -{} From bc4355891c9045567addbef2136d75a624a13a04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Iv=C3=A1n=20Suarez?= Date: Mon, 25 Jun 2018 20:22:05 -0500 Subject: [PATCH 5/5] Update first thing. (#6) Just a little text adjustment. --- PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index e6250a0de..f628be8c7 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -8,5 +8,5 @@ If you're making a pull request for a part of the tutorial on https://zeit.co to Make sure of these 2 things before making the pull request: -1. This Pull Request is against your own fork of the project and not the [zeit/now-github-starter](https://github.com/zeit/now-github-starter) repo +1. This Pull Request is against your own fork of the project and not the [zeit/now-github-starter](https://github.com/zeit/now-github-starter) repository. 2. Your Pull Request includes a `now.json` file with configuration settings. To get started, the file can even just contain `{}` and nothing else.