From e50912636059ceb427967dd0031865556b5be6c3 Mon Sep 17 00:00:00 2001 From: Alessandro Barbieri Date: Wed, 18 Feb 2026 21:33:35 +0100 Subject: [PATCH 1/2] fix melee hit talents being counted twice in TBC --- Modules/Data/Melee.lua | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Modules/Data/Melee.lua b/Modules/Data/Melee.lua index b6b11d02..5bdab6fa 100755 --- a/Modules/Data/Melee.lua +++ b/Modules/Data/Melee.lua @@ -75,18 +75,15 @@ function _Melee:GetHitTalentBonus() if Data:GetMeleeAttackSpeedOffHand() > 0 then mod = 2 * DataUtils:GetActiveTalentSpell({30816,30818,30819}) end - else + else ECS.IsClassic then -- Nature's Guidance mod = 1 * DataUtils:GetActiveTalentSpell({16180,16196,16198}) end - elseif classId == Data.PALADIN then - if ECS.IsTBC then + elseif classId == Data.ROGUE then + if ECS.IsClassic then -- precision - mod = 1 * DataUtils:GetActiveTalentSpell({20189,20192,20193}) + mod = 1 * DataUtils:GetActiveTalentSpell({13705,13832,13843,13844,13845}) end - elseif classId == Data.ROGUE then - -- precision - mod = 1 * DataUtils:GetActiveTalentSpell({13705,13832,13843,13844,13845}) elseif classId == Data.DEATHKNIGHT then -- Nerves of Cold Steel -- This assumes a DK is dual wielding and not only using a one-hand main hand weapon From 1a7f677c598df7cfcc2752f97c475a98b957ca72 Mon Sep 17 00:00:00 2001 From: Alessandro Barbieri Date: Wed, 18 Feb 2026 21:36:25 +0100 Subject: [PATCH 2/2] typo --- Modules/Data/Melee.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Data/Melee.lua b/Modules/Data/Melee.lua index 5bdab6fa..3af4991a 100755 --- a/Modules/Data/Melee.lua +++ b/Modules/Data/Melee.lua @@ -75,7 +75,7 @@ function _Melee:GetHitTalentBonus() if Data:GetMeleeAttackSpeedOffHand() > 0 then mod = 2 * DataUtils:GetActiveTalentSpell({30816,30818,30819}) end - else ECS.IsClassic then + elseif ECS.IsClassic then -- Nature's Guidance mod = 1 * DataUtils:GetActiveTalentSpell({16180,16196,16198}) end