Fixes NullReferenceException when accessing FieldDescriptor.IsPacked #9430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Jan 21, 2022
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
LGTM, but I'll let a member of the protobuf team actually approve.
elharo
reviewed
Jan 21, 2022
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
I don't know of a test for this, but it would help to add one that covers this bug.
MarcelRaschke
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
While developing a small service grpc-curl, I found a small bug in
FieldDescriptor.IsPackedthat was throwing aNullReferenceExceptionthat I had to workaround here:https://github.com/xoofx/grpc-curl/blob/f7bbe35af79713f278150b96ce51817807a06581/src/DynamicGrpc/DynamicMessageSerializer.cs#L434-L455
So this PR is a small bug fix. Though, I haven't found a test to update about it, not sure if we have any?