Skip to content

fix(FilePicker): Stop click event on checkbox column to allow multiselect#1192

Merged
skjnldsv merged 1 commit intomainfrom
fix/stop-click-event
Jan 18, 2024
Merged

fix(FilePicker): Stop click event on checkbox column to allow multiselect#1192
skjnldsv merged 1 commit intomainfrom
fix/stop-click-event

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 18, 2024

This changes two things:

  1. The click event on the whole checkbox column is stopped from bubbling
  2. Only add the click listener if required, same as the keyboard listener

@susnux susnux added bug Something isn't working 3. to review labels Jan 18, 2024
@susnux susnux requested review from Antreesy, Pytal and skjnldsv January 18, 2024 00:58
…lect

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/stop-click-event branch from 098f78d to 3908ba9 Compare January 18, 2024 01:23
@skjnldsv skjnldsv merged commit 7d3a052 into main Jan 18, 2024
@skjnldsv skjnldsv deleted the fix/stop-click-event branch January 18, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't pick directory in Dialog

2 participants