fix: incorrectly setting the name of currently running concurrent test#14335
Merged
SimenB merged 2 commits intojestjs:mainfrom Jul 21, 2023
dmitri-gb:fix-concurrent-snapshots
Merged
fix: incorrectly setting the name of currently running concurrent test#14335SimenB merged 2 commits intojestjs:mainfrom dmitri-gb:fix-concurrent-snapshots
SimenB merged 2 commits intojestjs:mainfrom
dmitri-gb:fix-concurrent-snapshots
Conversation
Test functions lose their async context when throttled by p-limit. This caused snapshot matchers not to work properly when the number of concurrent tests in a file was greater than the maxConcurrency config option. The fix is to set AsyncLocalStorage inside the throttled function.
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug in my previous submission (#14139).
Test functions lose their async context when throttled by p-limit. This caused snapshot matchers not to work properly when the number of concurrent tests in a file was greater than the
maxConcurrencyconfig option (which is 5 by default).The fix is to set
AsyncLocalStorageinside the throttled function.Test plan
Verified manually.