Skip to content

feat(material-luxon-adapter): add option to set first day of week#24027

Merged
wagnermaciel merged 2 commits intoangular:masterfrom
JiriBalcar:luxon-first-day-of-week
Dec 3, 2021
Merged

feat(material-luxon-adapter): add option to set first day of week#24027
wagnermaciel merged 2 commits intoangular:masterfrom
JiriBalcar:luxon-first-day-of-week

Conversation

@JiriBalcar
Copy link
Copy Markdown
Contributor

Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS

Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS
@JiriBalcar JiriBalcar requested a review from crisbeto as a code owner November 29, 2021 08:46
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 29, 2021
@JiriBalcar
Copy link
Copy Markdown
Contributor Author

@crisbeto I created new pull request instead of #23948 because messed up rebase. Can you please re-approve?

@crisbeto
Copy link
Copy Markdown
Member

Hmm, weird, the CI still decided not to run...

@JiriBalcar
Copy link
Copy Markdown
Contributor Author

I even created new fork and I saw that for the first time contributor you need to approve to CI to run. I do not know if there is needed some label to add for first time contributor?

@crisbeto
Copy link
Copy Markdown
Member

Those checks that need approval aren't the mandatory ones. Can you try the solution mentioned here? https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

@JiriBalcar
Copy link
Copy Markdown
Contributor Author

Honestly I do not know what should I do. I do not use CircleCI for any of my repos. I do not follow any projects there with my personal account. Maybe the checks will start after you approve this PR?

@crisbeto
Copy link
Copy Markdown
Member

I've approved it, but usually the CI runs as soon as you open the PR/push something to it.

@JiriBalcar
Copy link
Copy Markdown
Contributor Author

I tried to add one more commit and it looks like the CI started running?

@JiriBalcar JiriBalcar force-pushed the luxon-first-day-of-week branch from 16be499 to 36fe393 Compare November 29, 2021 11:42
@JiriBalcar
Copy link
Copy Markdown
Contributor Author

@crisbeto All checks passed, only one missing is target label. Can you please add it?

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 29, 2021
@JiriBalcar
Copy link
Copy Markdown
Contributor Author

Is everything OK now? I still see:

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.
1 skipped and 14 successful checks

@crisbeto
Copy link
Copy Markdown
Member

Yes, now it's fine.

@wagnermaciel
Copy link
Copy Markdown
Contributor

@crisbeto Same issue here. Can this be "target: minor" as well?

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 3, 2021
@crisbeto
Copy link
Copy Markdown
Member

crisbeto commented Dec 3, 2021

Yes, changed.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants