Skip to content

perf(multiple): don't emit fallbacks for CSS variables in experimental components#23912

Merged
mmalerba merged 1 commit intoangular:masterfrom
crisbeto:mdc-components-css-variables
Nov 15, 2021
Merged

perf(multiple): don't emit fallbacks for CSS variables in experimental components#23912
mmalerba merged 1 commit intoangular:masterfrom
crisbeto:mdc-components-css-variables

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Nov 6, 2021

Reworks the theming for the MDC-based components so that it doesn't emit fallback values for CSS variables. This trims ~27kb from the dev app theme.

Also wraps the structural styles of the MDC-based radio button and slide toggle who have been converted to the new MDC theming API.

…l components

Reworks the theming for the MDC-based components so that it doesn't emit fallback values for CSS variables. This trims ~27kb from the dev app theme.

Also wraps the structural styles of the MDC-based radio button and slide toggle who have been converted to the new MDC theming API.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2021
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 6, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2021
Copy link
Copy Markdown
Contributor

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 8, 2021
@mmalerba mmalerba merged commit 4350552 into angular:master Nov 15, 2021
mmalerba pushed a commit that referenced this pull request Nov 15, 2021
…l components (#23912)

Reworks the theming for the MDC-based components so that it doesn't emit fallback values for CSS variables. This trims ~27kb from the dev app theme.

Also wraps the structural styles of the MDC-based radio button and slide toggle who have been converted to the new MDC theming API.

(cherry picked from commit 4350552)
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants