Skip to content

fix(cdk/testing): simulate focusin/focusout events#23768

Merged
andrewseguin merged 1 commit intoangular:masterfrom
crisbeto:fake-focus-events-sequence
Oct 19, 2021
Merged

fix(cdk/testing): simulate focusin/focusout events#23768
andrewseguin merged 1 commit intoangular:masterfrom
crisbeto:fake-focus-events-sequence

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Oct 16, 2021

Fixes that our fake fallback focus events weren't dispatching focusin and focusout events as well.

Fixes #23757.

@crisbeto
fix(cdk/testing): simulate focusin/focusout events
ef7d9e0 
Fixes that our fake fallback focus events weren't dispatching `focusin` and `focusout` events as well.

Fixes angular#23757.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 16, 2021
@crisbeto crisbeto requested a review from mmalerba October 16, 2021 08:14
@crisbeto crisbeto requested a review from devversion as a code owner October 16, 2021 08:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 16, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2021
mmalerba
mmalerba approved these changes Oct 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewseguin andrewseguin merged commit 3cd505f into angular:master Oct 19, 2021
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
@crisbeto @andrewseguin
fix(cdk/testing): simulate focusin/focusout events (#23768)
59eee5d 
Fixes that our fake fallback focus events weren't dispatching `focusin` and `focusout` events as well.

Fixes #23757.

(cherry picked from commit 3cd505f)
andrewseguin pushed a commit that referenced this pull request Oct 19, 2021
@crisbeto @andrewseguin
fix(cdk/testing): simulate focusin/focusout events (#23768)
11e591b 
Fixes that our fake fallback focus events weren't dispatching `focusin` and `focusout` events as well.

Fixes #23757.

(cherry picked from commit 3cd505f)
@crisbeto crisbeto mentioned this pull request Oct 20, 2021
Open
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
@crisbeto
fix(cdk/testing): simulate focusin/focusout events (angular#23768)
c3007ea 
Fixes that our fake fallback focus events weren't dispatching `focusin` and `focusout` events as well.

Fixes angular#23757.
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

+1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(autocomplete): harness does not fire focusin event

4 participants

@crisbeto @devversion @mmalerba @andrewseguin