fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes#23559
Merged
andrewseguin merged 4 commits intoangular:masterfrom Sep 14, 2021
Merged
fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes#23559andrewseguin merged 4 commits intoangular:masterfrom
andrewseguin merged 4 commits intoangular:masterfrom
Conversation
…asses The MDC menu trigger had `.mat-menu-trigger` class because it was using the same directive as the non-MDC menu. This PR refactors the trigger and content directives to extend a common base class.
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Sep 9, 2021
devversion
approved these changes
Sep 10, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Sep 14, 2021
…asses (#23559) * fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes The MDC menu trigger had `.mat-menu-trigger` class because it was using the same directive as the non-MDC menu. This PR refactors the trigger and content directives to extend a common base class. * fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes * fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes * fixup! fix(material-experimental/mdc-menu): ensure mat-mdc- prefix on all classes (cherry picked from commit 771afd9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MDC menu trigger had
.mat-menu-triggerclass because it was usingthe same directive as the non-MDC menu. This PR refactors the trigger
and content directives to extend a common base class.