feat(material/dialog): add support for content sections in harness#23357
feat(material/dialog): add support for content sections in harness#23357amysorto merged 2 commits intoangular:masterfrom
Conversation
google-cla
bot
added
the
cla: yes
mmalerba
force-pushed
the
dialog-harness
branch
from
e91c1d8 to
771f91f
Compare
mmalerba
force-pushed
the
dialog-harness
branch
from
771f91f to
89fb56b
Compare
|
|
||
| /** Harness for interacting with a standard `MatDialog` in tests. */ | ||
| export class MatDialogHarness extends ContentContainerComponentHarness<string> { | ||
| export class MatDialogHarness extends ContentContainerComponentHarness<MatDialogSection | string> { |
There was a problem hiding this comment.
Not sure if we can do anything about it, but I think that the | string here basically removes any type checking for MatDialogSection.
There was a problem hiding this comment.
Yeah I left that as a reminder to eventually change it. I added a @breaking-change comment as well
| return (await this.host()).text(); | ||
| } | ||
|
|
||
| /** Gets the dialog's title text. */ |
There was a problem hiding this comment.
The JsDoc for these content areas should explain that they only work if you're using the corresponding premade content element
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM, aside from Jeremy's comment with the JSDoc.
mmalerba
force-pushed
the
dialog-harness
branch
from
89fb56b to
924ef62
Compare
mmalerba
added
action: merge
mmalerba
changed the title
mmalerba
force-pushed
the
dialog-harness
branch
from
924ef62 to
c324163
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.