Ensure final asset directory exists before writing cached files #12418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc486fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
approved these changes
Nov 15, 2024
Member
Princesseuh
left a comment
Princesseuh
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you very much for contributing this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Create the asset output folder before writing from cache.
If the first optimised image asset is cached astro re-optimises it as the cached file could not be written to the output directory, which is created after the cache step. Instead create the output directory first to prevent the unnecessary redownload and reprocessing of the first image asset.
Testing
Tested with the astro base template with a single remote image with 3 densities added, and successfully ran
pnpm --filter astro run test.Improved test site optimised image generation time on rebuilds from ~280ms to ~1ms, although this is an extreme case.
Docs
N/A: Minor fix in caching behaviour that should conform to existing user expectations